From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from colo.lackof.org (colo.lackof.org [198.49.126.79]) by dsl2.external.hp.com (Postfix) with ESMTP id 154C04841 for ; Sun, 9 Nov 2003 21:45:59 -0700 (MST) Date: Sun, 9 Nov 2003 21:45:56 -0700 From: Grant Grundler To: Joel Soete Cc: Matthew Wilcox , parisc-linux@lists.parisc-linux.org, Grant Grundler Subject: Re: [parisc-linux] fdisk problems 2.4 <-> 2.6 Message-ID: <20031110044556.GB16478@colo.lackof.org> References: <20031106222958.GJ26869@parcelfarce.linux.theplanet.co.uk> <3F969FFE000092BD@ocpmta2.freegates.net> <20031108015946.GC19436@colo.lackof.org> <3FACCC88.4010404@tiscali.be> <20031108194804.GA28929@colo.lackof.org> <3FAD6B1A.6060605@tiscali.be> <3FAE4639.6030200@tiscali.be> <20031109175735.GE2014@parcelfarce.linux.theplanet.co.uk> <3FAE8EA4.3050208@tiscali.be> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <3FAE8EA4.3050208@tiscali.be> Sender: parisc-linux-admin@lists.parisc-linux.org Errors-To: parisc-linux-admin@lists.parisc-linux.org List-Help: List-Post: List-Subscribe: , List-Id: parisc-linux developers list List-Unsubscribe: , List-Archive: On Sun, Nov 09, 2003 at 06:59:48PM +0000, Joel Soete wrote: > Just for remainder here is the alignement of uaccess.h (i just finished > to test on my c110 :)): > ----------><---------- > --- uaccess.h.orig 2004-04-20 21:03:59.000000000 +0200 > +++ uaccess.h 2003-11-09 18:47:06.000000000 +0100 > @@ -42,8 +42,8 @@ > #if BITS_PER_LONG == 32 > #define LDD_KERNEL(ptr) __get_kernel_bad(); > #define LDD_USER(ptr) __get_user_bad(); > -#define STD_KERNEL(x, ptr) __put_kernel_asm64((u32)x,ptr) > -#define STD_USER(x, ptr) __put_user_asm64((u32)x,ptr) > +#define STD_KERNEL(x, ptr) __put_kernel_asm64((u64)x,ptr) > +#define STD_USER(x, ptr) __put_user_asm64((u64)x,ptr) willy just removed the (u32) cast and things seem to work for him. Do you need the (u64) cast? ... > -static inline void __put_kernel_asm64(u64 x, void *ptr) ... > +#define __put_kernel_asm64(x, ptr) \ ... Why replace the static inline with a macro? static inline provides type checking and type "coercion" when it's not exactly right. > + __asm__ __volatile__ ( \ > + "\n1:\tstw\t%2,0(%1)\n" \ > + "2:\tstw\t%R2,4(%1)\n" \ What is "%R2" intended to be? Randolph pointed out this is broken before and I was wrong to commit this chunk to the 2.4 tree (I'm working on removing it now). thanks, grant