Re: [parisc-linux] error?

[Grant Grundler <grundler@parisc-linux.org>]

On Tue, Jan 27, 2004 at 03:16:16PM +0530, Naresh Kumar wrote:
>    r->end    = p->end;
>    r->flags  = IORESOURCE_MEM;
>    r->parent = r->sibling = r->child = NULL;
>    break;
>    lba_dev->gmmio_base = p->start;
>    break;
> 
>   case PAT_NPIOP:
>     printk(KERN_WARNING MODULE_NAME
>     " range[%d] : ignoring NPIOP (0x%lx)\n",
>     i, p->start);
>    break;
> -------------------------------------------------------------------
> 
> Please note the extra lines after the 'break;'. The version of
> 'lba_pci.c' is 1.7. Seems to have happened due to oversight.

Those are "extra"?
The version of code in linux-2.4 CVS has:
                case PAT_GMMIO:
                        printk(KERN_WARNING MODULE_NAME
                                " range[%d] : ignoring GMMIO (0x%lx)\n",
                                i, p->start);
                        lba_dev->gmmio_base = p->start;
                        break;

The code you quoted is missing the "case PAT_GMMIO" and printk.

thanks,
grant