Re: [parisc-linux] [PATCH] include/linux/soundcard.h endian fix

[Helge Deller <deller@gmx.de>]

On Sunday 07 March 2004 18:32, Stuart Brady wrote:
> Does anyone have any thoughts regarding this patch?
> 
> Index: soundcard.h
> ===================================================================
> RCS file: /var/cvs/linux-2.4/include/linux/soundcard.h,v
> retrieving revision 1.6
> diff -u -r1.6 soundcard.h
> --- soundcard.h	26 Jun 2003 15:08:08 -0000	1.6
> +++ soundcard.h	21 Feb 2004 16:04:12 -0000
> @@ -179,7 +179,7 @@
>   * Some big endian/little endian handling macros
>   */
>  
> -#if defined(_AIX) || defined(AIX) || defined(sparc) || defined(__sparc__) || defined(HPPA) || defined(PPC) || defined(__mc68000__)
> +#if defined(_AIX) || defined(AIX) || defined(sparc) || defined(__sparc__) || defined(HPPA) || defined(__hppa__) || defined(PPC) || defined(__powerpc__) || defined(__mc68000__)

I think you should just use "defined(__hppa__)" and simply 
drop the "defined(HPPA)" part.

> Or alternatively:
> 
> Index: soundcard.h
> ===================================================================
> RCS file: /var/cvs/linux-2.4/include/linux/soundcard.h,v
> retrieving revision 1.6
> diff -u -r1.6 soundcard.h
> --- soundcard.h	26 Jun 2003 15:08:08 -0000	1.6
> +++ soundcard.h	07 Mar 2004 17:26:23 -0000
> @@ -39,6 +39,13 @@
>  /* In Linux we need to be prepared for cross compiling */
>  #include <linux/ioctl.h>
>  
> +/* Endian macros. Note that they have a different meaning in the kernel. */
> +#ifdef __KERNEL__
> +#  include <asm/byteorder.h>
> +#else
> +#  include <endian.h>
> +#endif
> +
>  /*
>   *	Supported card ID numbers (Should be somewhere else?)
>   */
> @@ -179,13 +186,28 @@
>   * Some big endian/little endian handling macros
>   */
>  
> -#if defined(_AIX) || defined(AIX) || defined(sparc) || defined(__sparc__) || defined(HPPA) || defined(PPC) || defined(__mc68000__)
> -/* Big endian machines */
> -#  define _PATCHKEY(id) (0xfd00|id)
> -#  define AFMT_S16_NE AFMT_S16_BE
> -#else
> -#  define _PATCHKEY(id) ((id<<8)|0xfd)
> -#  define AFMT_S16_NE AFMT_S16_LE
> +#if defined(__BIG_ENDIAN)
> +#  if defined(__KERNEL__) || (defined(__BYTE_ORDER) && __BYTE_ORDER == __BIG_ENDIAN)
> +#    if defined(AFMT_S16_NE) || defined(_PATCHKEY)
> +#      error AFMT_S16_NE (or _PATCHKEY) is already defined
> +#    endif
> +#    define AFMT_S16_NE AFMT_S16_BE
> +#    define _PATCHKEY(id) (0xfd00|id)
> +#  endif
> +#endif
> +
> +#if defined(__LITTLE_ENDIAN)
> +#  if defined(__KERNEL__) || (defined(__BYTE_ORDER) && __BYTE_ORDER == __LITTLE_ENDIAN)
> +#    if defined(AFMT_S16_NE) || defined(_PATCHKEY)
> +#      error AFMT_S16_NE (or _PATCHKEY) is already defined
> +#    endif
> +#    define AFMT_S16_NE AFMT_S16_LE
> +#    define _PATCHKEY(id) ((id<<8)|0xfd)
> +#  endif
> +#endif
> +
> +#if !defined(AFMT_S16_NE)
> +#  error Failed to define AFMT_S16_NE
>  #endif
>  
>  /*

Personally I think either is OK.
 
> Should I be sending this elsewhere?

linux-kernel@vger.kernel.org ?

Helge