From: Grant Grundler <grundler@parisc-linux.org>
To: Stuart Brady <sdbrady@ntlworld.com>
Cc: parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] [PATCH] Harmony driver - Reject AFMT_S16_LE & Implement SNDCTL_DSP_CHANNELS
Date: Mon, 10 May 2004 23:24:51 -0600 [thread overview]
Message-ID: <20040511052451.GC27478@colo.lackof.org> (raw)
In-Reply-To: <20040223035601.GA988@calypso>
On Mon, Feb 23, 2004 at 03:56:01AM +0000, Stuart Brady wrote:
> On Sun, Feb 22, 2004 at 09:20:57AM +0000, Stuart Brady wrote:
>
> > + if (put_user(ival, (int *) arg))
> > + return -EFAULT;
>
> I've been looking at the specification, I think this should have been:
...
Hi Stuart,
Sorry for taking so long with this...I was expecting someone else
to reply and maybe missed it. A couple of minor problems with
your patch:
1) it's for 2.4 and I'm personally trying to focus on 2.6 tree now.
2.6 is ready for prime time. It's been my desktop/ftp/http server
(C3600) for the past couple of monthes and has proven very stable.
2) OSS is "decprecated" according to the 2.6 sound/Kconfig "Help".
Ie use ALSA instead. See SOUND_PRIME option.
3) if no one else wants to poke at the 2.4 harmony driver, I will
just apply your patches on good faith that it builds/works for you.
Have you tweaked it more since Feb?
In 2.6, ALSA harmony driver does NOT compile and that's disappointing.
thanks,
grant
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
next prev parent reply other threads:[~2004-05-11 5:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-22 9:20 [parisc-linux] [PATCH] Harmony driver - Reject AFMT_S16_LE (Little Endian) Stuart Brady
2004-02-22 10:30 ` Stuart Brady
2004-02-22 16:25 ` [parisc-linux] ad1889 driver/docs for c3k/j5k audio Grant Grundler
2004-05-29 0:06 ` [parisc-linux] " Stuart Brady
2004-05-29 0:25 ` Randolph Chung
2004-02-23 3:56 ` [parisc-linux] [PATCH] Harmony driver - Reject AFMT_S16_LE & Implement SNDCTL_DSP_CHANNELS Stuart Brady
2004-05-11 5:24 ` Grant Grundler [this message]
2004-05-11 13:07 ` Matthew Wilcox
2004-05-11 14:39 ` [parisc-linux] [PATCH] Harmony driver - Reject AFMT_S16_LE &Implement SNDCTL_DSP_CHANNELS Paul
2004-05-23 23:42 ` [parisc-linux] [PATCH] Harmony driver - Reject AFMT_S16_LE & Implement SNDCTL_DSP_CHANNELS Stuart Brady
2004-05-24 17:30 ` Ruediger Scholz
[not found] ` <20040524081200.3d14256b.varenet@esiee.fr>
2004-05-25 20:43 ` [parisc-linux] [PATCH] Harmony - buffer underrun crash fix Stuart Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040511052451.GC27478@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=sdbrady@ntlworld.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox