Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: Joel Soete <soete.joel@tiscali.be>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
	parisc-linux@parisc-linux.org
Subject: [parisc-linux] Re: ncr53c8xx patch for c110
Date: Sun, 20 Jun 2004 01:28:52 -0600	[thread overview]
Message-ID: <20040620072852.GC18353@colo.lackof.org> (raw)
In-Reply-To: <40D34A27.8060009@tiscali.be>

On Fri, Jun 18, 2004 at 08:01:43PM +0000, Joel Soete wrote:
> And all works fine now for me. Unfortunately I don't have other model (C, 
> D, R, J or K) using the same driver to test it more :(
> 
> I don't have any cvs ci access, so if there are no negative feedback can 
> somebody ci.

James owns this. I'll commit it if he tells me it's ok.

I didn't fully review this patch because of extra white space
changes like this one:

> -	struct scr_tblmove data [MAX_SCATTER];
> +	struct scr_tblmove data[MAX_SCATTER];

Not a reason to reject the patch. but it would be nice
if you submitted white space edits seperately.

> PS: I just noticed that this cut&past didn't respect my patch tabs (became 
> 8 space) so I attache also the original diff file (sorry for inconvenience

cut/paste almost nevery works.
Use an editor which can inline the patch file and sends mail
as plain/text. plain/text attachments work for me though it's
preferable to inline the patch.

thanks,
grant
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

  parent reply	other threads:[~2004-06-20  7:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <40BD9F8700009BB8@ocpmta2.freegates.net>
     [not found] ` <1087569206.2078.13.camel@mulgrave>
     [not found]   ` <40D30E3C.1010809@tiscali.be>
2004-06-18 20:01     ` [parisc-linux] ncr53c8xx patch for c110 Joel Soete
     [not found]       ` <35844.127.0.0.1.1087594933.squirrel@www.puszczka.com>
     [not found]         ` <20040618212600.GB12572@engsoc.org>
2004-06-19  0:33           ` [parisc-linux] A couple of minor patches for 2.6.7-pa1g John David Anglin
     [not found]           ` <35884.127.0.0.1.1087595933.squirrel@www.puszczka.com>
2004-06-19  1:11             ` [parisc-linux] A couple of minor patches for 2.6.7-pa1 Grant Grundler
     [not found]             ` <20040618215310.GD12572@engsoc.org>
2004-06-19  1:28               ` Matthew Wilcox
2004-06-19  3:41                 ` Kyle McMartin
2004-06-20  5:55       ` [parisc-linux] ncr53c8xx patch for c110 Andy Walker
2004-06-20  7:28       ` Grant Grundler [this message]
2004-06-21  7:48       ` Andy Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040620072852.GC18353@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=James.Bottomley@steeleye.com \
    --cc=parisc-linux@parisc-linux.org \
    --cc=soete.joel@tiscali.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox