Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: parisc-linux@parisc-linux.org
Subject: [parisc-linux] Re: -pa2 broke N4000/A500
Date: Wed, 14 Dec 2005 12:02:19 -0700	[thread overview]
Message-ID: <20051214190219.GC15899@colo.lackof.org> (raw)
In-Reply-To: <20051212151131.GD9286@parisc-linux.org>

On Mon, Dec 12, 2005 at 08:11:31AM -0700, Matthew Wilcox wrote:
> 
> Grant, your lba_pci changes to support rp3440 broke A500 and N4000.
> CVS2_6_15_RC5_PA1 boots fine.

Willy,
Just wanted to ACK on p-l mailing list that I did break this - apologies again.

I've posted the following patch (on top of what willy committed)
to parisc-linux-cvs mailing list and it only needs testing on C3000.

thanks,
grant

> willy@palinux:~/linux-2.6$ cvs up -rCVS2_6_15_RC5_PA2
> U Makefile
> U drivers/parisc/lba_pci.c
...


Index: drivers/parisc/lba_pci.c
===================================================================
RCS file: /var/cvs/linux-2.6/drivers/parisc/lba_pci.c,v
retrieving revision 1.35
diff -u -p -r1.35 lba_pci.c
--- drivers/parisc/lba_pci.c	12 Dec 2005 15:50:34 -0000	1.35
+++ drivers/parisc/lba_pci.c	12 Dec 2005 17:21:26 -0000
@@ -809,8 +809,7 @@ lba_fixup_bus(struct pci_bus *bus)
 		}
 		/* advertize Host bridge resources to PCI bus */
 		bus->resource[0] = &(ldev->hba.io_space);
-		bus->resource[1] = &(ldev->hba.lmmio_space);
-		i = 2;
+		i = 1;
 
 		if (ldev->hba.elmmio_space.start) {
 			err = request_resource(&iomem_resource,
@@ -831,7 +830,7 @@ lba_fixup_bus(struct pci_bus *bus)
 
 		/*   Overlaps with elmmio can (and should) fail here.
 		 *   We will prune (or ignore) the distributed range.

       reply	other threads:[~2005-12-14 19:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20051212151131.GD9286@parisc-linux.org>
2005-12-14 19:02 ` Grant Grundler [this message]
2005-12-14 23:01   ` [parisc-linux] Re: -pa2 broke N4000/A500 Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051214190219.GC15899@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=matthew@wil.cx \
    --cc=parisc-linux@parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox