From: Kyle McMartin <kyle@mcmartin.ca>
To: rubisher <rubi.sher@scarlet.be>
Cc: kyle <kyle@mcmartin.ca>, clameter <clameter@sgi.com>,
bunk <bunk@kernel.org>, kyle <kyle@parisc-linux.org>,
matthew <matthew@wil.cx>, grundler <grundler@parisc-linux.org>,
linux-parisc <linux-parisc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
rubisher <rubisher@scarlet.be>
Subject: Re: parisc compile error
Date: Thu, 14 Feb 2008 00:14:04 -0500 [thread overview]
Message-ID: <20080214051404.GA29980@phobos.i.cabal.ca> (raw)
In-Reply-To: <JW60A0$CF80A6CA85E28806A3D1EDDACE158868@scarlet.be>
On Wed, Feb 13, 2008 at 07:49:12AM +0100, rubisher wrote:
> --- include/asm-parisc/pgtable.h.Orig 2007-10-22 08:19:20.000000000 +0000
> +++ include/asm-parisc/pgtable.h 2008-02-12 16:28:36.000000000 +0000
> +extern void *vmalloc_start;
> +#define PCXL_DMA_MAP_SIZE (8*1024*1024)
> +#define VMALLOC_START ((unsigned long)vmalloc_start)
> +/* this is a fixmap remnant, see fixmap.h */
> +#define VMALLOC_END (KERNEL_MAP_END)
> +
i moved this to fixmap.h, since i think it makes more sense there,
really.
> static inline void pte_free_kernel(struct mm_struct *mm, struct page *pte)
> {
> pgtable_page_dtor(pte);
> pte_free_kernel(page_address((pte));
> }
>
this is a stunning bit of ignorant patching courtesy of
2f569afd9ced9ebec9a6eb3dbf6f83429be0a7b4 which:
-#define pte_free(mm, page) pte_free_kernel(page_address(page))
+static inline void pte_free_kernel(struct mm_struct *mm, struct page
*pte)
+{
+ pgtable_page_dtor(pte);
+ pte_free_kernel(page_address((pte));
+}
only wrong on *two* counts.
anyway, fixed this up. sigh.
next prev parent reply other threads:[~2008-02-14 5:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 6:49 parisc compile error rubisher
2008-02-14 5:14 ` Kyle McMartin [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-02-18 10:32 rubisher
2008-02-18 17:14 ` Kyle McMartin
2008-02-15 10:44 rubisher
2008-02-15 10:42 rubisher
2008-02-13 12:42 rubisher
2008-02-14 5:22 ` Kyle McMartin
2008-02-17 22:36 ` Kyle McMartin
2008-02-07 23:12 Adrian Bunk
2008-02-07 23:20 ` Kyle McMartin
2008-02-07 23:33 ` Christoph Lameter
2008-02-07 23:34 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214051404.GA29980@phobos.i.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=bunk@kernel.org \
--cc=clameter@sgi.com \
--cc=grundler@parisc-linux.org \
--cc=kyle@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=rubi.sher@scarlet.be \
--cc=rubisher@scarlet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox