From: Russell King <rmk-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
To: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
Cc: linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org,
linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org,
Kyle McMartin <kyle-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>,
Matthew Wilcox <matthew-Ztpu424NOJ8@public.gmane.org>,
Grant Grundler <grundler-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>,
linux-parisc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
Chris Zankel <chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org>
Subject: Re: [patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2
Date: Mon, 3 Mar 2008 19:44:09 +0000 [thread overview]
Message-ID: <20080303194408.GC20251@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080228000437.880811124-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
On Wed, Feb 27, 2008 at 05:04:37PM -0700, Bjorn Helgaas wrote:
> There are many implementations of pcibios_enable_resources() that differ
> in minor ways that look more like bugs than architectural differences.
> This patch series consolidates most of them to use the x86 version.
>
> Changes between v1 and v2:
>
> - Moved ARM bridge enable to new platform_pci_enable_device(),
> called by pcibios_enable_device()
Looks fine. However, long term I've no idea what to do about this because
I don't remember the reasoning behind it. So to change it risks breakage
of one sort or another.
It might have been something to do with the Mobility Cardbus docking
station, which adds a pair of P2P bridges onto the PCI chain downstream
of the Cardbus controller, and then a full PCI bus containing USB, VGA,
and other peripherals.
This _once_ used to work with Linux but I suspect as a result of "fixing"
other issues its now utterly broken.
In any case, that docking station isn't ARM specific in any way; merely
a toy Alan Cox sent me. When I gave up my PCMCIA maintainership, I gave
up trying to keep it supported by Linux.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-03-03 19:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080228000437.880811124@ldl.fc.hp.com>
[not found] ` <20080228001053.209248743@ldl.fc.hp.com>
2008-02-28 17:31 ` [patch 5/6] PARISC: move PERR & SERR enables out of pcibios_enable_resources() Grant Grundler
2008-03-03 18:30 ` Jesse Barnes
2008-02-28 17:38 ` Kyle McMartin
[not found] ` <20080228001053.404893334@ldl.fc.hp.com>
2008-02-28 17:55 ` [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations David Howells
[not found] ` <20080228001053.404893334-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
2008-03-03 18:45 ` Jesse Barnes
[not found] ` <200803031045.07054.jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
2008-03-03 19:10 ` Bjorn Helgaas
[not found] ` <20080228001053.013269726@ldl.fc.hp.com>
2008-03-03 17:59 ` [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources() Jesse Barnes
2008-03-03 20:35 ` Benjamin Herrenschmidt
2008-03-03 20:43 ` Jesse Barnes
2008-03-06 15:06 ` Russell King - ARM Linux
[not found] ` <20080306150640.GL3283-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2008-03-06 15:42 ` Bjorn Helgaas
[not found] ` <20080228000437.880811124-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
2008-03-03 19:44 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303194408.GC20251@flint.arm.linux.org.uk \
--to=rmk-lfz/pmaqli7xmaaqvzeohq@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=bjorn.helgaas-VXdhtT5mjnY@public.gmane.org \
--cc=chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org \
--cc=grundler-6jwH94ZQLHl74goWV3ctuw@public.gmane.org \
--cc=kyle-6jwH94ZQLHl74goWV3ctuw@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org \
--cc=linux-parisc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=matthew-Ztpu424NOJ8@public.gmane.org \
--cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox