From: Mike Frysinger <vapier@gentoo.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Helge Deller <deller@gmx.de>, Kyle McMartin <kyle@mcmartin.ca>,
"linux-parisc" <linux-parisc@vger.kernel.org>
Subject: Re: [PATCH] parisc: BUG_ON() cleanup
Date: Tue, 6 Jan 2009 11:49:50 -0500 [thread overview]
Message-ID: <200901061149.52015.vapier@gentoo.org> (raw)
In-Reply-To: <1231255233.7090.5.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
On Tuesday 06 January 2009 10:20:33 James Bottomley wrote:
> On Tue, 2009-01-06 at 12:57 +0100, Helge Deller wrote:
> > - convert a few "if (xx) BUG();" to BUG_ON(xx)
>
> This is fine
>
> > - remove a few printk()s, as we get a backtrace with BUG_ON() anyway
>
> This is less helpful. Each of the printks explains why the bug
> triggers. In theory you can work this out from the BUG_ON line number,
> but *only* if your source files match those of the reporter, which isn't
> the case in an annoyingly large number of bug reports ... speaking as
> someone who seems to get to diagnose large numbers of bugs, it makes my
> life harder.
i think those comments go beyond parisc. perhaps we should add a
BUG_ON_ANNOTATED() that includes another printk ?
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
prev parent reply other threads:[~2009-01-06 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 11:57 [PATCH] parisc: BUG_ON() cleanup Helge Deller
2009-01-06 15:20 ` James Bottomley
2009-01-06 16:09 ` Helge Deller
2009-01-06 16:49 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901061149.52015.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=deller@gmx.de \
--cc=kyle@mcmartin.ca \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox