From: Grant Grundler <grundler@parisc-linux.org>
To: Kyle McMartin <kyle@mcmartin.ca>, Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org
Subject: [PATCH][linux-2.6] Fix gcc 4.4 warning in lba_pci.c
Date: Sat, 20 Jun 2009 16:46:13 -0600 [thread overview]
Message-ID: <20090620224613.GB853@lackof.org> (raw)
gcc 4.4 warns about:
drivers/parisc/lba_pci.c: In function 'lba_pat_resources':
drivers/parisc/lba_pci.c:1099: warning: the frame size of 8280 bytes is larger than 4096 bytes
The problem is we declare two large structures on the stack. They don't need
to be on the stack since they are only used during LBA initialization (which
is serialized). Moving to be "static".
Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
---
diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c
index 59fbbf1..7535cb3 100644
--- a/drivers/parisc/lba_pci.c
+++ b/drivers/parisc/lba_pci.c
@@ -980,13 +980,17 @@ static void
lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
{
unsigned long bytecnt;
- pdc_pat_cell_mod_maddr_block_t pa_pdc_cell; /* PA_VIEW */
- pdc_pat_cell_mod_maddr_block_t io_pdc_cell; /* IO_VIEW */
long io_count;
long status; /* PDC return status */
long pa_count;
int i;
+ /* We don't need additional locking around the use of pdc_pat_cell
+ ** since init time PDC device discovery is already serialized.
+ */
+ static pdc_pat_cell_mod_maddr_block_t pa_pdc_cell; /* PA_VIEW */
+ static pdc_pat_cell_mod_maddr_block_t io_pdc_cell; /* IO_VIEW */
+
/* return cell module (IO view) */
status = pdc_pat_cell_module(&bytecnt, pa_dev->pcell_loc, pa_dev->mod_index,
PA_VIEW, & pa_pdc_cell);
next reply other threads:[~2009-06-20 22:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 22:46 Grant Grundler [this message]
2009-06-20 23:11 ` [PATCH][linux-2.6] Fix gcc 4.4 warning in lba_pci.c Grant Grundler
2009-06-20 23:26 ` James Bottomley
2009-06-20 23:29 ` Grant Grundler
2009-06-21 0:06 ` John David Anglin
2009-06-23 6:31 ` Grant Grundler
2009-06-23 11:39 ` Carlos O'Donell
2009-06-24 5:31 ` Grant Grundler
2009-06-24 13:47 ` John David Anglin
2009-06-20 23:34 ` Grant Grundler
2009-06-20 23:39 ` John David Anglin
2009-06-20 23:51 ` Grant Grundler
2009-06-20 23:55 ` [PATCH][linux-2.6] v4 : " Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090620224613.GB853@lackof.org \
--to=grundler@parisc-linux.org \
--cc=deller@gmx.de \
--cc=kyle@mcmartin.ca \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).