From: Rusty Russell <rusty@rustcorp.com.au>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Helge Deller <deller@gmx.de>,
"linux-parisc" <linux-parisc@vger.kernel.org>,
Roland McGrath <roland@redhat.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: kernel segv with 2.6.31-rc6 ?
Date: Tue, 18 Aug 2009 12:48:52 +0930 [thread overview]
Message-ID: <200908181248.52572.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1250549376.7858.96.camel@mulgrave.site>
On Tue, 18 Aug 2009 08:19:36 am James Bottomley wrote:
> The root cause is a duplicate section name (.text); is this legal?
I'd be happy to fail to load it. There might be sysfs issues with it
too.
> However, there's a problem with commit
> 6d76013381ed28979cd122eb4b249a88b5e384fa in that if you fail to allocate
> a mod->sect_attrs (in this case it's null because of the duplication),
> it still gets used without checking in add_notes_attrs()
>
> This should fix it
No, the real problem is that it ignores failure. I'd much rather fail
the module load than various features mysteriously MIA.
Which brings us to "patches which don't go thru the maintainer" (or
perhaps, non-responsive maintainers who get bypassed).
Thanks,
Rusty.
next prev parent reply other threads:[~2009-08-18 3:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 21:31 kernel segv with 2.6.31-rc6 ? Helge Deller
2009-08-17 22:04 ` James Bottomley
2009-08-17 22:49 ` James Bottomley
2009-08-17 23:54 ` Roland McGrath
2009-08-18 3:18 ` Rusty Russell [this message]
2009-08-18 3:55 ` James Bottomley
2009-08-18 5:06 ` Roland McGrath
2009-08-19 0:09 ` James Bottomley
2009-08-19 0:14 ` Roland McGrath
2009-08-19 0:54 ` James Bottomley
2009-08-19 1:31 ` Roland McGrath
2009-08-19 1:38 ` James Bottomley
2009-08-19 18:10 ` Roland McGrath
2009-08-25 7:59 ` Rusty Russell
2009-08-25 19:24 ` Roland McGrath
2009-08-26 12:20 ` Rusty Russell
2009-08-26 17:54 ` Roland McGrath
2009-08-20 11:51 ` Helge Deller
2009-08-20 12:25 ` Helge Deller
2009-08-20 18:55 ` John David Anglin
2009-08-20 21:45 ` Helge Deller
2009-08-20 21:50 ` James Bottomley
2009-08-20 22:07 ` Roland McGrath
2009-08-20 23:01 ` John David Anglin
2009-08-20 23:23 ` Roland McGrath
2009-08-21 0:03 ` John David Anglin
2009-08-25 21:49 ` Mike Frysinger
2009-08-25 7:37 ` Rusty Russell
2009-11-27 22:11 ` Helge Deller
2009-11-30 4:41 ` Roland McGrath
2009-08-20 11:58 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908181248.52572.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=James.Bottomley@hansenpartnership.com \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).