From: Grant Grundler <grundler@parisc-linux.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Kyle McMartin <kyle@mcmartin.ca>,
Helge Deller <deller@gmx.de>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH 14/21] drivers/parisc/iosapic.c: Remove unnecessary kzalloc cast
Date: Tue, 1 Jun 2010 15:02:12 -0600 [thread overview]
Message-ID: <20100601210212.GA19544@lackof.org> (raw)
In-Reply-To: <ba7d48df75ca37c39b0e519921c116a617e71db7.1275360951.git.joe@perches.com>
On Mon, May 31, 2010 at 08:23:16PM -0700, Joe Perches wrote:
> Convert kzalloc to kcalloc
>
> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Grant Grundler <grundler@parisc-linux.org>
thanks,
grant
> ---
> drivers/parisc/iosapic.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c
> index c768367..3e6f56c 100644
> --- a/drivers/parisc/iosapic.c
> +++ b/drivers/parisc/iosapic.c
> @@ -891,8 +891,8 @@ void *iosapic_register(unsigned long hpa)
> isi->isi_version = iosapic_rd_version(isi);
> isi->isi_num_vectors = IOSAPIC_IRDT_MAX_ENTRY(isi->isi_version) + 1;
>
> - vip = isi->isi_vector = (struct vector_info *)
> - kzalloc(sizeof(struct vector_info) * isi->isi_num_vectors, GFP_KERNEL);
> + vip = isi->isi_vector = kcalloc(isi->isi_num_vectors,
> + sizeof(struct vector_info), GFP_KERNEL);
> if (vip == NULL) {
> kfree(isi);
> return NULL;
> --
> 1.7.0.3.311.g6a6955
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-06-01 21:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1275360951.git.joe@perches.com>
2010-06-01 3:23 ` [PATCH 14/21] drivers/parisc/iosapic.c: Remove unnecessary kzalloc cast Joe Perches
2010-06-01 21:02 ` Grant Grundler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601210212.GA19544@lackof.org \
--to=grundler@parisc-linux.org \
--cc=deller@gmx.de \
--cc=jejb@parisc-linux.org \
--cc=joe@perches.com \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox