From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dzianis Kahanovich <mahatma@eu.by>, Helge Deller <deller@gmx.de>,
linux-next@vger.kernel.org, linux-input@vger.kernel.org,
Linux/m68k <linux-m68k@lists.linux-m68k.org>,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH/RFC] input: hil_mlc - Fix hil_mlc_serio_id file2alias failure
Date: Tue, 12 Oct 2010 23:56:02 -0700 [thread overview]
Message-ID: <20101013065602.GA7014@core.coreip.homeip.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1010122111270.6491@ayla.of.borg>
On Tue, Oct 12, 2010 at 09:17:49PM +0200, Geert Uytterhoeven wrote:
> Commit e288bf7c346360ac9dafbc1b6d7b6b1a82b51616 ("Input: HIL keyboard and
> serio - add missing MODULE_DEVICE_TABLE()") caused the following build
> failure on m68k/allmodconfig:
>
> FATAL: drivers/input/serio/hil_mlc: struct serio_device_id is not terminated with a NULL entry!
>
> hil_mlc_serio_id is not an array, but a single struct serio_device_id entry.
> Fix the build by converting it into an array, and adding a NULL entry.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Build failure in linux-next:
> http://kisskb.ellerman.id.au/kisskb/buildresult/3385851/
>
> I'm not sure this is the right fix, as hil_mlc_serio_id is a catch-all ID.
> Perhaps the MODULE_DEVICE_TABLE() should just be removed again instead?
>
Gah, that original patch was incorrect, I should not have applied it at
all... The serio_device_id in question is for serio port that is being
created by the driver and thus of course should not be used in
MODULE_DEVICE_TABLE().
I'll drop it from my 'next' queue.
--
Dmitry
next prev parent reply other threads:[~2010-10-13 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 19:17 [PATCH/RFC] input: hil_mlc - Fix hil_mlc_serio_id file2alias failure Geert Uytterhoeven
2010-10-13 6:56 ` Dmitry Torokhov [this message]
2010-10-14 15:43 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013065602.GA7014@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mahatma@eu.by \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox