From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: rkuo@codeaurora.org, tglx@linutronix.de, linas@codeaurora.org,
mingo@elte.hu, a.p.zijlstra@chello.nl, dhowells@redhat.com,
yasutake.koichi@jp.panasonic.com, akpm@linux-foundation.org,
benh@kernel.crashing.org, jesper.nilsson@axis.com,
cmetcalf@tilera.com, linux@arm.linux.org.uk,
jejb@parisc-linux.org, deller@gmx.de, vapier@gentoo.org
Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-am33-list@redhat.com, linux-parisc@vger.kernel.org
Subject: [PATCH 2/4] mn10300/CPU hotplug: Add missing call to notify_cpu_starting()
Date: Thu, 22 Mar 2012 16:58:47 +0530 [thread overview]
Message-ID: <20120322112830.17063.88766.stgit@srivatsabhat.in.ibm.com> (raw)
In-Reply-To: <20120322112735.17063.21791.stgit@srivatsabhat.in.ibm.com>
The scheduler depends on receiving the CPU_STARTING notification, without
which we end up into a lot of trouble. So add the missing call to
notify_cpu_starting() in the bringup code.
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
---
arch/mn10300/kernel/smp.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/mn10300/kernel/smp.c b/arch/mn10300/kernel/smp.c
index 9242e9f..25ca7fe 100644
--- a/arch/mn10300/kernel/smp.c
+++ b/arch/mn10300/kernel/smp.c
@@ -875,10 +875,14 @@ static void __init smp_online(void)
cpu = smp_processor_id();
- local_irq_enable();
+ notify_cpu_starting(cpu);
+ ipi_call_lock();
set_cpu_online(cpu, true);
- smp_wmb();
+ ipi_call_unlock();
+
+ local_irq_enable();
+
}
/**
next prev parent reply other threads:[~2012-03-22 11:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 11:28 [PATCH 0/4] arch/CPU hotplug: Add missing CPU Hotplug bits to fix nasty issues Srivatsa S. Bhat
2012-03-22 11:28 ` [PATCH 1/4] hexagon/CPU hotplug: Add missing call to notify_cpu_starting() Srivatsa S. Bhat
2012-04-03 21:09 ` Richard Kuo
2012-03-22 11:28 ` Srivatsa S. Bhat [this message]
2012-03-22 11:28 ` [PATCH 3/4] parisc/CPU " Srivatsa S. Bhat
2012-03-22 11:29 ` [PATCH 4/4] tile/CPU " Srivatsa S. Bhat
2012-04-03 19:48 ` Chris Metcalf
2012-03-22 12:13 ` [PATCH 0/4] arch/CPU hotplug: Add missing CPU Hotplug bits to fix nasty issues Peter Zijlstra
2012-03-22 12:32 ` Peter Zijlstra
2012-03-22 14:53 ` James Bottomley
2012-03-22 14:55 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322112830.17063.88766.stgit@srivatsabhat.in.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cmetcalf@tilera.com \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=jejb@parisc-linux.org \
--cc=jesper.nilsson@axis.com \
--cc=linas@codeaurora.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=rkuo@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).