From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: torvalds@linux-foundation.org
Cc: akpm@linux-foundation.org, mingo@kernel.org,
a.p.zijlstra@chello.nl, mpatocka@redhat.com,
stepanm@codeaurora.org, tglx@linutronix.de,
James.Bottomley@hansenpartnership.com, deller@gmx.de,
dhowells@redhat.com, yasutake.koichi@jp.panasonic.com,
eike-kernel@sf-tec.de, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org, srivatsa.bhat@linux.vnet.ibm.com,
linux-am33-list@redhat.com
Subject: [RESEND PATCH 1/2] parisc/CPU hotplug: Add missing call to notify_cpu_starting()
Date: Wed, 16 May 2012 00:32:17 +0530 [thread overview]
Message-ID: <20120515190157.22459.91924.stgit@srivatsabhat> (raw)
In-Reply-To: <20120515190115.22459.93544.stgit@srivatsabhat>
The scheduler depends on receiving the CPU_STARTING notification, without
which we end up into a lot of trouble. So add the missing call to
notify_cpu_starting() in the bringup code.
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-and-Tested-by: Mikulas Patocka <mpatocka@redhat.com>
Acked-and-Tested-by: Tobias Ulmer <tobiasu@tmux.org>
Tested-by: John David Anglin <dave.anglin@bell.net>
---
arch/parisc/kernel/smp.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/arch/parisc/kernel/smp.c b/arch/parisc/kernel/smp.c
index 0bb1d63..4dc7b79 100644
--- a/arch/parisc/kernel/smp.c
+++ b/arch/parisc/kernel/smp.c
@@ -31,6 +31,7 @@
#include <linux/delay.h>
#include <linux/bitops.h>
#include <linux/ftrace.h>
+#include <linux/cpu.h>
#include <linux/atomic.h>
#include <asm/current.h>
@@ -295,8 +296,13 @@ smp_cpu_init(int cpunum)
printk(KERN_CRIT "CPU#%d already initialized!\n", cpunum);
machine_halt();
- }
+ }
+
+ notify_cpu_starting(cpunum);
+
+ ipi_call_lock();
set_cpu_online(cpunum, true);
+ ipi_call_unlock();
/* Initialise the idle task for this CPU */
atomic_inc(&init_mm.mm_count);
next prev parent reply other threads:[~2012-05-15 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 19:01 [RESEND PATCH 0/2] arch/CPU hotplug: Add missing CPU Hotplug bits to fix nasty issues Srivatsa S. Bhat
2012-05-15 19:02 ` Srivatsa S. Bhat [this message]
2012-05-15 19:02 ` [RESEND PATCH 2/2] mn10300/CPU hotplug: Add missing call to notify_cpu_starting() Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515190157.22459.91924.stgit@srivatsabhat \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpatocka@redhat.com \
--cc=stepanm@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox