public inbox for linux-parisc@vger.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: "H. Peter Anvin" <hpa@zytor.com>,
	linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	John David Anglin <dave.anglin@bell.net>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Rolf Eike Beer <eike-kernel@sf-tec.de>,
	Ian Kent <raven@themaw.net>,
	autofs@vger.kernel.org
Subject: [PATCH] unbreak automounter support on 64-bit kernel with 32-bit userspace (v2)
Date: Mon, 4 Feb 2013 20:39:52 +0100	[thread overview]
Message-ID: <20130204193952.GA5785@p100.box> (raw)
In-Reply-To: <510AE21D.2090002@zytor.com>

automount-support is broken on the parisc architecture, because the existing
#if list does not include a check for defined(__hppa__). The HPPA (parisc)
architecture is similiar to other 64bit Linux targets where we have to define
autofs_wqt_t (which is passed back and forth to user space) as int type which
has a size of 32bit across 32 and 64bit kernels.

During the discussion on the mailing list, H. Peter Anvin suggested to invert
the #if list since only specific platforms (specifically those who do not have
a 32bit userspace, like IA64 and Alpha) should have autofs_wqt_t as unsigned
long type.

This suggestion is probably the best way to go, since Arm64 (and maybe others?)
seems to have a non-working automounter. So in the long run even for other new
upcoming architectures this inverted check seem to be the best solution, since
it will not require them to change this #if again (unless they are 64bit only).

Signed-off-by: Helge Deller <deller@gmx.de>
CC: James Bottomley <James.Bottomley@HansenPartnership.com>
CC: Catalin Marinas <catalin.marinas@arm.com>
CC: Rolf Eike Beer <eike-kernel@sf-tec.de>
CC: H. Peter Anvin <hpa@zytor.com>
CC: Ian Kent <raven@themaw.net>


diff --git a/include/uapi/linux/auto_fs.h b/include/uapi/linux/auto_fs.h
index 77cdba9..bb991df 100644
--- a/include/uapi/linux/auto_fs.h
+++ b/include/uapi/linux/auto_fs.h
@@ -28,25 +28,16 @@
 #define AUTOFS_MIN_PROTO_VERSION	AUTOFS_PROTO_VERSION
 
 /*
- * Architectures where both 32- and 64-bit binaries can be executed
- * on 64-bit kernels need this.  This keeps the structure format
- * uniform, and makes sure the wait_queue_token isn't too big to be
- * passed back down to the kernel.
- *
- * This assumes that on these architectures:
- * mode     32 bit    64 bit
- * -------------------------
- * int      32 bit    32 bit
- * long     32 bit    64 bit
- *
- * If so, 32-bit user-space code should be backwards compatible.
+ * The wait_queue_token (autofs_wqt_t) is part of a structure which is passed
+ * back to the kernel via ioctl from userspace. On architectures where 32- and
+ * 64-bit userspace binaries can be executed it's important that the size of
+ * autofs_wqt_t stays constant between 32- and 64-bit Linux kernels so that we
+ * do not break the binary ABI interface by changing the structure size.
  */

  parent reply	other threads:[~2013-02-04 19:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31 20:01 [PATCH] parisc: unbreak automounter support on 64-bit kernel with 32-bit userspace Helge Deller
2013-01-31 20:26 ` James Bottomley
2013-01-31 21:00   ` Rolf Eike Beer
2013-01-31 21:29   ` H. Peter Anvin
2013-01-31 21:42     ` James Bottomley
2013-01-31 21:46       ` H. Peter Anvin
2013-01-31 22:10         ` Rolf Eike Beer
2013-01-31 23:13           ` H. Peter Anvin
2013-02-01 14:51           ` Catalin Marinas
2013-02-04 19:39     ` Helge Deller [this message]
2013-02-04 21:35       ` [PATCH] unbreak automounter support on 64-bit kernel with 32-bit userspace (v2) H. Peter Anvin
2013-02-06  5:58       ` Ian Kent
2013-02-06 17:08         ` H. Peter Anvin
2013-02-06 17:21       ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130204193952.GA5785@p100.box \
    --to=deller@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=autofs@vger.kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dave.anglin@bell.net \
    --cc=eike-kernel@sf-tec.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=raven@themaw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox