From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH] unbreak automounter support on 64-bit kernel with 32-bit userspace (v2) Date: Wed, 6 Feb 2013 17:21:20 +0000 Message-ID: <20130206172120.GJ26454@arm.com> References: <510AE21D.2090002@zytor.com> <20130204193952.GA5785@p100.box> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "H. Peter Anvin" , "linux-parisc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Bottomley , John David Anglin , Rolf Eike Beer , Ian Kent , "autofs@vger.kernel.org" To: Helge Deller Return-path: In-Reply-To: <20130204193952.GA5785@p100.box> List-ID: List-Id: linux-parisc.vger.kernel.org On Mon, Feb 04, 2013 at 07:39:52PM +0000, Helge Deller wrote: > automount-support is broken on the parisc architecture, because the existing > #if list does not include a check for defined(__hppa__). The HPPA (parisc) > architecture is similiar to other 64bit Linux targets where we have to define > autofs_wqt_t (which is passed back and forth to user space) as int type which > has a size of 32bit across 32 and 64bit kernels. > > During the discussion on the mailing list, H. Peter Anvin suggested to invert > the #if list since only specific platforms (specifically those who do not have > a 32bit userspace, like IA64 and Alpha) should have autofs_wqt_t as unsigned > long type. > > This suggestion is probably the best way to go, since Arm64 (and maybe others?) > seems to have a non-working automounter. So in the long run even for other new > upcoming architectures this inverted check seem to be the best solution, since > it will not require them to change this #if again (unless they are 64bit only). > > Signed-off-by: Helge Deller > CC: James Bottomley > CC: Catalin Marinas > CC: Rolf Eike Beer > CC: H. Peter Anvin > CC: Ian Kent Acked-by: Catalin Marinas