From: Helge Deller <deller@gmx.de>
To: linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: [PATCH] parisc: check hardcoded value of SHMLBA against value reported by firmware
Date: Tue, 29 Oct 2013 22:05:44 +0100 [thread overview]
Message-ID: <20131029210544.GA18167@p100.box> (raw)
Our value of SHMLBA is hardcoded to 4MB on parisc due to aliasing restrictions
of the platform. The firmware function PDC_CACHE does return the machine
dependend value of this aliasing requirement.
So, if there is a difference between those two - which we don't expect - let's
report it at least.
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c
index c035673..3523e20 100644
--- a/arch/parisc/kernel/cache.c
+++ b/arch/parisc/kernel/cache.c
@@ -142,6 +142,15 @@ parisc_cache_init(void)
if (pdc_cache_info(&cache_info) < 0)
panic("parisc_cache_init: pdc_cache_info failed");
+ /*
+ * The alias field returned by PDC_CACHE specifies the aliasing
+ * boundaries for virtual addresses. So, let's verify if our hardcoded
+ * value of SHMLBA (4 MB) is correct for this machine.
+ */
+ if ((4096UL << (cache_info.dc_conf.cc_alias-1)) != SHMLBA)
+ pr_warn("WARNING: PDC_CACHE returns aliasing of %lu kB.\n",
+ (4UL << (cache_info.dc_conf.cc_alias-1)));
+
#if 0
printk("ic_size %lx dc_size %lx it_size %lx\n",
cache_info.ic_size,
next reply other threads:[~2013-10-29 21:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 21:05 Helge Deller [this message]
2013-10-29 21:10 ` [PATCH] parisc: check hardcoded value of SHMLBA against value reported by firmware John David Anglin
2013-10-29 21:11 ` Helge Deller
2013-10-29 21:26 ` James Bottomley
2013-10-29 21:28 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029210544.GA18167@p100.box \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).