From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: jejb@parisc-linux.org, deller@gmx.de, tiwai@suse.de,
jkosina@suse.cz, dave.anglin@bell.net, joe@perches.com,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: Remove sizeof(frame) from call to get_sigframe
Date: Mon, 7 Jul 2014 13:55:54 +0100 [thread overview]
Message-ID: <20140707135554.1c52342c@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <1404530457-4739-1-git-send-email-xerofoify@gmail.com>
On Fri, 4 Jul 2014 23:20:57 -0400
Nicholas Krause <xerofoify@gmail.com> wrote:
> This removes the sizeof(frame) from the call to get_sigframe on line
> 243 in order to fix the call to this function as the sizeof in not
> needed to call this function.
If you are going to submit patches then
- actually read what you are submitting
- check it actually compiles
- run it on the system in question and verify your changed code paths are
used
*then* consider submitting it, otherwise all you are doing is wasting
people's time.
Alan
next prev parent reply other threads:[~2014-07-07 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 3:20 [PATCH] parisc: Remove sizeof(frame) from call to get_sigframe Nicholas Krause
2014-07-05 3:58 ` Joe Perches
2014-07-05 4:01 ` Nick Krause
2014-07-07 12:55 ` One Thousand Gnomes [this message]
2014-07-07 13:05 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707135554.1c52342c@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=jejb@parisc-linux.org \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox