From: Helge Deller <deller@gmx.de>
To: linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
John David Anglin <dave.anglin@bell.net>
Subject: [PATCH] parisc: Fix TLB related boot crash with PA8000-PA8700 CPUs
Date: Wed, 7 Dec 2016 21:52:40 +0100 [thread overview]
Message-ID: <20161207205240.GA5917@ls3530> (raw)
Machines with PA8000-PA8700 CPUs crash during startup while we measure
and calculate a good threshold for the TLB flush.
Avoid this crash by simply skipping the test until we figure out what
really triggers the crash.
Cc: <stable@vger.kernel.org> # v3.18+
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c
index c263301..63c10ea 100644
--- a/arch/parisc/kernel/cache.c
+++ b/arch/parisc/kernel/cache.c
@@ -393,6 +393,14 @@ void __init parisc_setup_cache_timing(void)
/* calculate TLB flush threshold */
+ /* skip TLB measure on PA8000-PA8700 CPUs */
+ if (boot_cpu_data.cpu_type >= pcxu &&
+ boot_cpu_data.cpu_type <= pcxw2) {
+ threshold = max(cache_info.it_size, cache_info.dt_size);
+ threshold *= PAGE_SIZE;
+ goto set_tlb_threshold;
+ }
+
alltime = mfctl(16);
flush_tlb_all();
alltime = mfctl(16) - alltime;
@@ -411,6 +419,8 @@ void __init parisc_setup_cache_timing(void)
alltime, size, rangetime);
threshold = PAGE_ALIGN(num_online_cpus() * size * alltime / rangetime);
+
+set_tlb_threshold:
if (threshold)
parisc_tlb_flush_threshold = threshold;
printk(KERN_INFO "TLB flush threshold set to %lu KiB\n",
next reply other threads:[~2016-12-07 20:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 20:52 Helge Deller [this message]
2016-12-07 21:34 ` [PATCH] parisc: Fix TLB related boot crash with PA8000-PA8700 CPUs Aaro Koskinen
2016-12-07 22:17 ` John David Anglin
2016-12-08 19:58 ` Helge Deller
2016-12-08 20:00 ` [PATCH] parisc: Fix TLB related boot crash on SMP machines Helge Deller
2016-12-08 20:49 ` John David Anglin
2016-12-08 21:15 ` Helge Deller
2016-12-08 21:21 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207205240.GA5917@ls3530 \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox