From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] parisc: perf: return -EFAULT on error Date: Thu, 8 Dec 2016 18:10:15 +0300 Message-ID: <20161208151014.GW8176@mwanda> References: <20161208113200.GC11382@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, kernel-janitors@vger.kernel.org To: bojan prtvar Return-path: In-Reply-To: List-ID: On Thu, Dec 08, 2016 at 03:53:42PM +0100, bojan prtvar wrote: > Hi Dan, > > On Thu, Dec 8, 2016 at 12:32 PM, Dan Carpenter wrote: > > - if ((err = copy_from_user(&image_type, buf, sizeof(uint32_t))) != 0) > > - return err; > > Why not delete err? Gar... I'm sorry. I'll resend. regards, dan carpenter