From: Andrew Lunn <andrew@lunn.ch>
To: Yuval Shaia <yuval.shaia@oracle.com>
Cc: klassert@mathematik.tu-chemnitz.de, pcnet32@frontier.com,
hsweeten@visionengravers.com, jeffrey.t.kirsher@intel.com,
cooldavid@cooldavid.org, mcuos.com@gmail.com,
nic_swsd@realtek.com, ralf@linux-mips.org, romieu@fr.zoreil.com,
nico@fluxnic.net, oneukum@suse.com, davem@davemloft.net,
tremyfr@gmail.com, paul.gortmaker@windriver.com,
jarod@redhat.com, green.hu@gmail.com, f.fainelli@gmail.com,
edumazet@google.com, shchers@gmail.com, stephen.boyd@linaro.org,
fgao@48lvckh6395k16k5.yundunddos.com, tklauser@distanz.ch,
jay.vosburgh@canonical.com, robert.jarzmik@free.fr,
jeremy.linton@arm.com, rmk+kernel@armlinux.org.uk,
stephen@networkplumber.org, arnd@arndb.de, gerg@linux-m68k.org,
allan@asix.com.tw, chris.roth@usask.ca, hayeswang@realtek.com,
mario_limonciello@dell.com, netdev@vger.kern
Subject: Re: [PATCH] net/{mii,smsc}: Make mii_ethtool_get_link_ksettings and smc_netdev_get_ecmd return void
Date: Sun, 4 Jun 2017 21:01:33 +0200 [thread overview]
Message-ID: <20170604190133.GB10273@lunn.ch> (raw)
In-Reply-To: <20170604172200.4177-1-yuval.shaia@oracle.com>
> diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c
> index da02041..017f48c 100644
> --- a/drivers/net/cris/eth_v10.c
> +++ b/drivers/net/cris/eth_v10.c
> @@ -1417,10 +1417,9 @@ static int e100_get_link_ksettings(struct net_device *dev,
> {
> struct net_local *np = netdev_priv(dev);
> u32 supported;
> - int err;
>
> spin_lock_irq(&np->lock);
> - err = mii_ethtool_get_link_ksettings(&np->mii_if, cmd);
> + mii_ethtool_get_link_ksettings(&np->mii_if, cmd);
> spin_unlock_irq(&np->lock);
>
> /* The PHY may support 1000baseT, but the Etrax100 does not. */
> @@ -1432,7 +1431,7 @@ static int e100_get_link_ksettings(struct net_device *dev,
> ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported,
> supported);
>
> - return err;
> + return 0;
> }
How far are going planning on going? It seems like
*_get_link_ksettings() now all return a useless 0. Do you plan to
change ethtool_ops and make if void all the way up?
Andrew
next prev parent reply other threads:[~2017-06-04 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 17:22 [PATCH] net/{mii, smsc}: Make mii_ethtool_get_link_ksettings and smc_netdev_get_ecmd return void Yuval Shaia
2017-06-04 19:01 ` Andrew Lunn [this message]
2017-06-04 19:49 ` [PATCH] net/{mii,smsc}: " Yuval Shaia
2017-06-05 15:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604190133.GB10273@lunn.ch \
--to=andrew@lunn.ch \
--cc=allan@asix.com.tw \
--cc=arnd@arndb.de \
--cc=chris.roth@usask.ca \
--cc=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fgao@48lvckh6395k16k5.yundunddos.com \
--cc=gerg@linux-m68k.org \
--cc=green.hu@gmail.com \
--cc=hayeswang@realtek.com \
--cc=hsweeten@visionengravers.com \
--cc=jarod@redhat.com \
--cc=jay.vosburgh@canonical.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jeremy.linton@arm.com \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=mario_limonciello@dell.com \
--cc=mcuos.com@gmail.com \
--cc=netdev@vger.kern \
--cc=nic_swsd@realtek.com \
--cc=nico@fluxnic.net \
--cc=oneukum@suse.com \
--cc=paul.gortmaker@windriver.com \
--cc=pcnet32@frontier.com \
--cc=ralf@linux-mips.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=romieu@fr.zoreil.com \
--cc=shchers@gmail.com \
--cc=stephen.boyd@linaro.org \
--cc=stephen@networkplumber.org \
--cc=tklauser@distanz.ch \
--cc=tremyfr@gmail.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox