From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helge Deller Subject: Re: [patch V2 04/29] parisc: Use lockup_detector_stop() Date: Thu, 14 Sep 2017 10:59:17 +0200 Message-ID: <20170914085917.GA24723@ls3530> References: <20170912193654.321505854@linutronix.de> <20170912194146.407385557@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: LKML , Ingo Molnar , Peter Zijlstra , Borislav Petkov , Andrew Morton , Sebastian Siewior , Nicholas Piggin , Don Zickus , Chris Metcalf , Ulrich Obergfell , linux-parisc@vger.kernel.org, Helge Deller To: Thomas Gleixner Return-path: In-Reply-To: <20170912194146.407385557@linutronix.de> List-ID: List-Id: linux-parisc.vger.kernel.org * Thomas Gleixner : > The broken lockup_detector_suspend/resume() interface is going away. Use > the new lockup_detector_soft_poweroff() interface to stop the watchdog from > the busy looping power off routine. > > Signed-off-by: Thomas Gleixner > Cc: Don Zickus > Cc: Chris Metcalf > Cc: linux-parisc@vger.kernel.org > Cc: Peter Zijlstra > Cc: Sebastian Siewior > Cc: Nicholas Piggin > Cc: Ulrich Obergfell > Cc: Borislav Petkov > Cc: Andrew Morton > Cc: Helge Deller > Link: http://lkml.kernel.org/r/20170831073053.281414373@linutronix.de > > --- > arch/parisc/kernel/process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/parisc/kernel/process.c > +++ b/arch/parisc/kernel/process.c > @@ -146,7 +146,7 @@ void machine_power_off(void) > > /* prevent soft lockup/stalled CPU messages for endless loop. */ > rcu_sysrq_start(); > - lockup_detector_suspend(); > + lockup_detector_soft_poweroff(); > for (;;); > } Thomas, thanks for cleaning that up. You may add to patches 03/04: Acked-by: Helge Deller On a side-note, there is sadly no general function like turn_off_all_kind_of_runtime_hang_detectors() which turns off *all* detectors at once (including soft lockup detector). I've seen another detector complaing at runtime that we were hanging here. I would need to dig up more info if you are interested... Helge