* [PATCH v3 5/7] drivers: s390: Avoids building drivers if ARCH is not s390.
@ 2018-09-28 1:48 Leonardo Brás
0 siblings, 0 replies; 4+ messages in thread
From: Leonardo Brás @ 2018-09-28 1:48 UTC (permalink / raw)
To: lkcamp
Cc: Alexander Shishkin, Finn Thain, Robert Richter,
James E.J. Bottomley, Helge Deller, Martin Schwidefsky,
Heiko Carstens, Geert Uytterhoeven, linux-kernel, linux-m68k,
oprofile-list, linux-parisc, linux-s390
Avoids building s390 drivers if 'make drivers/s390/' is called but
ARCH is not s390.
Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
---
drivers/s390/Makefile | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/s390/Makefile b/drivers/s390/Makefile
index a863b0462b43..0575f02dba45 100644
--- a/drivers/s390/Makefile
+++ b/drivers/s390/Makefile
@@ -3,7 +3,7 @@
# Makefile for the S/390 specific device drivers
#
-obj-y += cio/ block/ char/ crypto/ net/ scsi/ virtio/
-
-drivers-y += drivers/s390/built-in.a
-
+ifeq ($(ARCH),s390)
+ obj-y += cio/ block/ char/ crypto/ net/ scsi/ virtio/
+ drivers-y += drivers/s390/built-in.a
+endif
--
2.19.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 5/7] drivers: s390: Avoids building drivers if ARCH is not s390.
2018-09-28 2:08 [PATCH v3 0/7] Remove errors building drivers/DRIVERNAME Leonardo Brás
@ 2018-09-28 2:08 ` Leonardo Brás
2018-10-01 12:46 ` Heiko Carstens
0 siblings, 1 reply; 4+ messages in thread
From: Leonardo Brás @ 2018-09-28 2:08 UTC (permalink / raw)
To: lkcamp
Cc: Leonardo Brás, Alexander Shishkin, Finn Thain,
Robert Richter, James E.J. Bottomley, Helge Deller,
Martin Schwidefsky, Heiko Carstens, Geert Uytterhoeven,
linux-kernel, linux-m68k, oprofile-list, linux-parisc, linux-s390
Avoids building s390 drivers if 'make drivers/s390/' is called but
ARCH is not s390.
Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
---
drivers/s390/Makefile | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/s390/Makefile b/drivers/s390/Makefile
index a863b0462b43..0575f02dba45 100644
--- a/drivers/s390/Makefile
+++ b/drivers/s390/Makefile
@@ -3,7 +3,7 @@
# Makefile for the S/390 specific device drivers
#
-obj-y += cio/ block/ char/ crypto/ net/ scsi/ virtio/
-
-drivers-y += drivers/s390/built-in.a
-
+ifeq ($(ARCH),s390)
+ obj-y += cio/ block/ char/ crypto/ net/ scsi/ virtio/
+ drivers-y += drivers/s390/built-in.a
+endif
--
2.19.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 5/7] drivers: s390: Avoids building drivers if ARCH is not s390.
2018-09-28 2:08 ` [PATCH v3 5/7] drivers: s390: Avoids building drivers if ARCH is not s390 Leonardo Brás
@ 2018-10-01 12:46 ` Heiko Carstens
2018-10-04 1:00 ` Leonardo Bras
0 siblings, 1 reply; 4+ messages in thread
From: Heiko Carstens @ 2018-10-01 12:46 UTC (permalink / raw)
To: Leonardo Brás
Cc: lkcamp, Alexander Shishkin, Finn Thain, Robert Richter,
James E.J. Bottomley, Helge Deller, Martin Schwidefsky,
Geert Uytterhoeven, linux-kernel, linux-m68k, oprofile-list,
linux-parisc, linux-s390
On Thu, Sep 27, 2018 at 11:08:14PM -0300, Leonardo Brás wrote:
> Avoids building s390 drivers if 'make drivers/s390/' is called but
> ARCH is not s390.
>
> Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
> ---
> drivers/s390/Makefile | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/s390/Makefile b/drivers/s390/Makefile
> index a863b0462b43..0575f02dba45 100644
> --- a/drivers/s390/Makefile
> +++ b/drivers/s390/Makefile
> @@ -3,7 +3,7 @@
> # Makefile for the S/390 specific device drivers
> #
>
> -obj-y += cio/ block/ char/ crypto/ net/ scsi/ virtio/
> -
> -drivers-y += drivers/s390/built-in.a
> -
> +ifeq ($(ARCH),s390)
> + obj-y += cio/ block/ char/ crypto/ net/ scsi/ virtio/
> + drivers-y += drivers/s390/built-in.a
> +endif
And then somebody wants to build with e.g. "make drivers/s390/cio/" and it
still doesn't work. So _if_ this should be supported then it should work
with all directory levels and all configuration options. Otherwise this is
going to be a never ending story.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 5/7] drivers: s390: Avoids building drivers if ARCH is not s390.
2018-10-01 12:46 ` Heiko Carstens
@ 2018-10-04 1:00 ` Leonardo Bras
0 siblings, 0 replies; 4+ messages in thread
From: Leonardo Bras @ 2018-10-04 1:00 UTC (permalink / raw)
To: Heiko Carstens
Cc: lkcamp, Alexander Shishkin, Finn Thain, Robert Richter,
James E.J. Bottomley, Helge Deller, Martin Schwidefsky,
Geert Uytterhoeven, linux-kernel, linux-m68k, oprofile-list,
linux-parisc, linux-s390
On Mon, Oct 1, 2018 at 9:46 AM Heiko Carstens <heiko.carstens@de.ibm.com> w=
rote:
>
> On Thu, Sep 27, 2018 at 11:08:14PM -0300, Leonardo Br=C3=A1s wrote:
> > Avoids building s390 drivers if 'make drivers/s390/' is called but
> > ARCH is not s390.
> >
> > Signed-off-by: Leonardo Br=C3=A1s <leobras.c@gmail.com>
> > ---
> > drivers/s390/Makefile | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/s390/Makefile b/drivers/s390/Makefile
> > index a863b0462b43..0575f02dba45 100644
> > --- a/drivers/s390/Makefile
> > +++ b/drivers/s390/Makefile
> > @@ -3,7 +3,7 @@
> > # Makefile for the S/390 specific device drivers
> > #
> >
> > -obj-y +=3D cio/ block/ char/ crypto/ net/ scsi/ virtio/
> > -
> > -drivers-y +=3D drivers/s390/built-in.a
> > -
> > +ifeq ($(ARCH),s390)
> > + obj-y +=3D cio/ block/ char/ crypto/ net/ scsi/ virtio/
> > + drivers-y +=3D drivers/s390/built-in.a
> > +endif
>
> And then somebody wants to build with e.g. "make drivers/s390/cio/" and i=
t
> still doesn't work. So _if_ this should be supported then it should work
> with all directory levels and all configuration options. Otherwise this i=
s
> going to be a never ending story.
>
It makes sense.
I proposed this change to help me solving a problem described here
(https://lkml.org/lkml/2018/10/3/707), and for this it was enough if it did=
n't
build when "make drivers/s390/" was called.
Sorry I didn't send the e-mail with the reason earlier.
For solving my problem it was not necessary, but if you think it's interest=
ing,
I could refactor all drivers/s390 Makefiles to make them all build only if
we are dealing with the s390 architecture.
What do you think?
Thanks for the reply,
Leonardo Bras
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-04 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-28 1:48 [PATCH v3 5/7] drivers: s390: Avoids building drivers if ARCH is not s390 Leonardo Brás
-- strict thread matches above, loose matches on Subject: below --
2018-09-28 2:08 [PATCH v3 0/7] Remove errors building drivers/DRIVERNAME Leonardo Brás
2018-09-28 2:08 ` [PATCH v3 5/7] drivers: s390: Avoids building drivers if ARCH is not s390 Leonardo Brás
2018-10-01 12:46 ` Heiko Carstens
2018-10-04 1:00 ` Leonardo Bras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox