From: Sven Schnelle <svens@stackframe.org>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: deller@gmx.de, linux-parisc@vger.kernel.org,
linux-parisc-owner@vger.kernel.org
Subject: Re: [PATCH 4/6] parisc: use pr_debug() in kernel/module.c
Date: Wed, 29 May 2019 19:54:06 +0200 [thread overview]
Message-ID: <20190529175406.GC15295@t470p.stackframe.org> (raw)
In-Reply-To: <d1ada6ef8eb96dd679b8ba973ded263a@sf-tec.de>
Hi,
On Tue, May 28, 2019 at 10:24:32AM +0200, Rolf Eike Beer wrote:
> > -#define CONST
> > +#define CONST
> > int module_frob_arch_sections(CONST Elf_Ehdr *hdr,
> > CONST Elf_Shdr *sechdrs,
> > CONST char *secstrings,
> > @@ -619,7 +613,7 @@ int apply_relocate_add(Elf_Shdr *sechdrs,
> > /* See note about special handling of SEGREL32 at
> > * the beginning of this file.
> > */
> > - *loc = fsel(val, addend);
> > + *loc = fsel(val, addend);
> > break;
> > case R_PARISC_SECREL32:
> > /* 32-bit section relative address. */
>
> You are sneaking in unrelated whitespace fixes. I just want to let you know
> that you got caught ;)
Not contributing often to the linux kernel i'm not sure what the policy is. IMHO
it's okay to fix whitespace errors when working on patches. If Helge says this
is a problem i remove the whitespace changes.
Regards
Sven
next prev parent reply other threads:[~2019-05-29 17:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 19:04 [PATCH 0/6] Dynamic FTRACE for PA-RISC Sven Schnelle
2019-05-27 19:04 ` [PATCH 1/6] parisc: add support for patching multiple words Sven Schnelle
2019-05-28 8:19 ` Rolf Eike Beer
2019-05-29 17:49 ` Sven Schnelle
2019-05-29 17:58 ` Rolf Eike Beer
2019-05-29 18:18 ` Sven Schnelle
2019-05-27 19:04 ` [PATCH 2/6] parisc: add spinlock to patch function Sven Schnelle
2019-05-27 19:04 ` [PATCH 3/6] parisc: add WARN_ON() to clear_fixmap Sven Schnelle
2019-05-27 19:04 ` [PATCH 4/6] parisc: use pr_debug() in kernel/module.c Sven Schnelle
2019-05-28 8:24 ` Rolf Eike Beer
2019-05-29 17:54 ` Sven Schnelle [this message]
2019-05-27 19:04 ` [PATCH 5/6] compiler.h: add CC_USING_PATCHABLE_FUNCTION_ENTRY Sven Schnelle
2019-05-27 19:04 ` [PATCH 6/6] parisc: add dynamic ftrace Sven Schnelle
2019-05-28 8:26 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529175406.GC15295@t470p.stackframe.org \
--to=svens@stackframe.org \
--cc=deller@gmx.de \
--cc=eike-kernel@sf-tec.de \
--cc=linux-parisc-owner@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).