From: Sven Schnelle <svens@stackframe.org>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: deller@gmx.de, linux-parisc@vger.kernel.org
Subject: Re: [PATCH v2 1/6] parisc: add support for patching multiple words
Date: Wed, 5 Jun 2019 22:21:40 +0200 [thread overview]
Message-ID: <20190605202140.GB779@t470p.stackframe.org> (raw)
In-Reply-To: <3798054.dHnqrmMtG0@daneel.sf-tec.de>
Hi,
On Tue, Jun 04, 2019 at 09:21:34PM +0200, Rolf Eike Beer wrote:
> Sven Schnelle wrote:
> > + while (len >= 4) {
> > + *p++ = *insn++;
> > + addr += sizeof(u32);
> > + len -= sizeof(u32);
> > + if (len && !((unsigned long)addr & ~PAGE_MASK)) {
>
> if (len && offset_in_page(addr) == 0)
>
> This is a bit more obvious to me. YMMV.
It is. I'll update the patch and send a v3. Thanks!
Sven
next prev parent reply other threads:[~2019-06-05 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 18:34 [PATCH v2 0/6] Dynamic FTRACE for PA-RISC Sven Schnelle
2019-06-04 18:34 ` [PATCH v2 1/6] parisc: add support for patching multiple words Sven Schnelle
2019-06-04 19:21 ` Rolf Eike Beer
2019-06-05 20:21 ` Sven Schnelle [this message]
2019-06-04 18:34 ` [PATCH v2 2/6] parisc: add spinlock to patch function Sven Schnelle
2019-06-04 18:34 ` [PATCH v2 3/6] parisc: add WARN_ON() to clear_fixmap Sven Schnelle
2019-06-04 18:34 ` [PATCH v2 4/6] parisc: use pr_debug() in kernel/module.c Sven Schnelle
2019-06-04 18:34 ` [PATCH v2 5/6] compiler.h: add CC_USING_PATCHABLE_FUNCTION_ENTRY Sven Schnelle
2019-06-04 18:34 ` [PATCH v2 6/6] parisc: add dynamic ftrace Sven Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605202140.GB779@t470p.stackframe.org \
--to=svens@stackframe.org \
--cc=deller@gmx.de \
--cc=eike-kernel@sf-tec.de \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).