From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C83C47404 for ; Fri, 11 Oct 2019 09:45:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A3D721A4A for ; Fri, 11 Oct 2019 09:45:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727755AbfJKJpc (ORCPT ); Fri, 11 Oct 2019 05:45:32 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34704 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726863AbfJKJpc (ORCPT ); Fri, 11 Oct 2019 05:45:32 -0400 Received: from v22018046084765073.goodsrv.de ([185.183.158.195] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iIrUH-0004RM-Md; Fri, 11 Oct 2019 09:45:29 +0000 Date: Fri, 11 Oct 2019 11:45:28 +0200 From: Christian Brauner To: Kees Cook Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, luto@kernel.org, oleg@redhat.com, tglx@linutronix.de, wad@chromium.org, x86@kernel.org, Borislav Petkov Subject: Re: [PATCH v1] seccomp: simplify secure_computing() Message-ID: <20191011094527.ftevtkeitjqafhdd@wittgenstein> References: <20190920131907.6886-1-christian.brauner@ubuntu.com> <20190924064420.6353-1-christian.brauner@ubuntu.com> <201910101450.0B13B7F@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201910101450.0B13B7F@keescook> User-Agent: NeoMutt/20180716 Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Thu, Oct 10, 2019 at 02:53:24PM -0700, Kees Cook wrote: > On Tue, Sep 24, 2019 at 08:44:20AM +0200, Christian Brauner wrote: > > Afaict, the struct seccomp_data argument to secure_computing() is unused > > by all current callers. So let's remove it. > > The argument was added in [1]. It was added because having the arch > > supply the syscall arguments used to be faster than having it done by > > secure_computing() (cf. Andy's comment in [2]). This is not true anymore > > though. > > Yes; thanks for cleaning this up! > > > diff --git a/arch/s390/kernel/ptrace.c b/arch/s390/kernel/ptrace.c > > index ad71132374f0..ed80bdfbf5fe 100644 > > --- a/arch/s390/kernel/ptrace.c > > +++ b/arch/s390/kernel/ptrace.c > > @@ -439,7 +439,7 @@ static int poke_user(struct task_struct *child, addr_t addr, addr_t data) > > long arch_ptrace(struct task_struct *child, long request, > > unsigned long addr, unsigned long data) > > { > > - ptrace_area parea; > > + ptrace_area parea; > > int copied, ret; > > > > switch (request) { > > If this were whitespace cleanup in kernel/seccomp.c, I'd take it without > flinching. As this is only tangentially related and in an arch > directory, I've dropped this hunk out of a cowardly fear of causing > (a likely very unlikely) merge conflict. > > I'd rather we globally clean up trailing whitespace at the end of -rc1 > and ask Linus to run some crazy script. :) Oh that was on accident probably. It usally happens because I have vim do whitespace fixups automatically and then they end up slipping in... Sorry. Thanks for removing it! :) Christian