From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C4E7CA9EBB for ; Thu, 24 Oct 2019 08:51:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 527D521872 for ; Thu, 24 Oct 2019 08:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571907100; bh=yne+q2OXrSImKWVSiY3azP5LbAIN48uZobw79sAWlFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=U+dGAQOmVnRLO60L4WYpeE9ApU/tAVP9gr7F5DcRCRGmUavH2Gio1afQr93YZA3o5 QPbi2KVQqq2HfNjYh8MVNcGGcLIkl7LX85pZ4/8hjNPdcUftoa5yC5Qq7Ai+Pqk6np MNfGfUGw4WdIWvsXleJ2Dupkwrrn6zKEtPbeDq7c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438396AbfJXIvh (ORCPT ); Thu, 24 Oct 2019 04:51:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:38770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730621AbfJXIvg (ORCPT ); Thu, 24 Oct 2019 04:51:36 -0400 Received: from rapoport-lnx (nesher1.haifa.il.ibm.com [195.110.40.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C60620684; Thu, 24 Oct 2019 08:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571907096; bh=yne+q2OXrSImKWVSiY3azP5LbAIN48uZobw79sAWlFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xpwdM9yMJT3vwdJLbOI5KIPEEpEYHfqEfSqqKjUi5ZSSU5mfa5OWBh563R00Omteo 1c6jhSHIeQS869/swtQtZqJJbFD6Wthojjuy5NInms0kvWdnjQNTpkjIm45S4+i5rs whgYfB8T+i91x0MJgndRbMS9GGWr99hizp8ehhpU= Date: Thu, 24 Oct 2019 11:51:24 +0300 From: Mike Rapoport To: Rolf Eike Beer Cc: linux-mm@kvack.org, Andrew Morton , Anton Ivanov , Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Richard Weinberger , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, sparclinux@vger.kernel.org, Mike Rapoport , linux-parisc-owner@vger.kernel.org Subject: Re: [PATCH 08/12] parisc: use pgtable-nopXd instead of 4level-fixup Message-ID: <20191024085123.GB12281@rapoport-lnx> References: <1571822941-29776-1-git-send-email-rppt@kernel.org> <1571822941-29776-9-git-send-email-rppt@kernel.org> <70339cfc547e2fa0f6b98fefb1b1a9fa@sf-tec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70339cfc547e2fa0f6b98fefb1b1a9fa@sf-tec.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Wed, Oct 23, 2019 at 12:20:29PM +0200, Rolf Eike Beer wrote: > >diff --git a/arch/parisc/include/asm/page.h > >b/arch/parisc/include/asm/page.h > >index 93caf17..1d339ee 100644 > >--- a/arch/parisc/include/asm/page.h > >+++ b/arch/parisc/include/asm/page.h > >@@ -42,48 +42,54 @@ typedef struct { unsigned long pte; } pte_t; /* > >either 32 or 64bit */ > > > > /* NOTE: even on 64 bits, these entries are __u32 because we allocate > > * the pmd and pgd in ZONE_DMA (i.e. under 4GB) */ > >-typedef struct { __u32 pmd; } pmd_t; > > typedef struct { __u32 pgd; } pgd_t; > > typedef struct { unsigned long pgprot; } pgprot_t; > > > >-#define pte_val(x) ((x).pte) > >-/* These do not work lvalues, so make sure we don't use them as such. */ > >+#if CONFIG_PGTABLE_LEVELS == 3 > >+typedef struct { __u32 pmd; } pmd_t; > >+#define __pmd(x) ((pmd_t) { (x) } ) > >+/* pXd_val() do not work lvalues, so make sure we don't use them as such. > >*/ > > For me it sounds like there is something missing, maybe an "as" before > lvalues? Right, "as lvalues" makes sense. > And it was "These", so plural, and now it is singular, so do -> does? There's also pgd_val() a few lines below, it's just not visible in the patch. > Eike -- Sincerely yours, Mike.