From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD176C433F5 for ; Fri, 5 Nov 2021 19:55:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE45660EB4 for ; Fri, 5 Nov 2021 19:55:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232644AbhKET55 (ORCPT ); Fri, 5 Nov 2021 15:57:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231967AbhKET54 (ORCPT ); Fri, 5 Nov 2021 15:57:56 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0DAFC061714 for ; Fri, 5 Nov 2021 12:55:16 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id l3so7857853pfu.13 for ; Fri, 05 Nov 2021 12:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9BE6s8fqPo7si+9hU4rA5Zx86f+DZzTQse4zPUGhzI0=; b=K2JJlQhfcPmTgqNvZMN022hVqYO6eH/8AxgqtQORXguKa8NM7Wo9wB2mxAZqdkfBJP ppNT5YQE5mZot/jPo/6TlUfDTaT2X/TQF4QITNnD9iyLfm2WK1BHpKNEffle0LCGh2b4 sndnUuP6PC/3WEqL8sKDAROrX/WuH+koIv7G8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9BE6s8fqPo7si+9hU4rA5Zx86f+DZzTQse4zPUGhzI0=; b=2YWDaFJSvo8OiYaJIfzYQAUNpLEZM029Oj6A9a6Dvldv7O/BUhK2fk0ceWqkJPiubD WPnHhkahvbPeyMZ468tTDdI2uwoGIQp+AQdLTAL9/mVSUVHSV6sUsX6MTncszQercuqj +b1jPEkhNP3zrlt5MnR6JMYItPyL8NBLQIvIPSXPBho5XN6rEZ2WAQgXQpj4//zf9wDW AWKKqx8nOwPmqYCIjKhrbR7TXkgGV8EnLOchpdJh23jTyLURojInpqMdLhbn9byaA4Lr dalIAm+EVe5zTlQMURjIn+wPcBhVvtlww77e7AiMkYHhbKa94Fe3yshlVkrjaRih0x8t QTvQ== X-Gm-Message-State: AOAM532vCy8l2j1CPUuNLpZx1B3So19m9IdDSZ/Vx0+Gpt8B2u5ENe53 OQHNuNs2ABVLK6oTB0QcY3sXLWeDZTEc9A== X-Google-Smtp-Source: ABdhPJz6C1Esv0poMTWA9OAwWm7CjuefshOeHGRbguhnJfCUTwK+nbqOyx93dmWbZ6c/B8FKQ1fObg== X-Received: by 2002:a62:ee10:0:b0:49f:9994:354e with SMTP id e16-20020a62ee10000000b0049f9994354emr7956301pfi.21.1636142116413; Fri, 05 Nov 2021 12:55:16 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d13sm8252555pfu.196.2021.11.05.12.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Nov 2021 12:55:16 -0700 (PDT) Date: Fri, 5 Nov 2021 12:55:15 -0700 From: Kees Cook To: Ard Biesheuvel Cc: Guenter Roeck , Linus Torvalds , Linux Kernel Mailing List , Helge Deller , linux-parisc Subject: Re: parisc build failures in mainline kernel Message-ID: <202111051254.1AAE34273@keescook> References: <20211104031554.GA34798@roeck-us.net> <77dc70f4-879a-eb5c-2dd6-682b4c7cfd03@roeck-us.net> <202111051242.86E9DBF@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Fri, Nov 05, 2021 at 08:43:52PM +0100, Ard Biesheuvel wrote: > On Fri, 5 Nov 2021 at 20:43, Kees Cook wrote: > > > > On Wed, Nov 03, 2021 at 09:45:47PM -0700, Linus Torvalds wrote: > > > On Wed, Nov 3, 2021 at 9:30 PM Guenter Roeck wrote: > > > > > > > > Unfortunately not. With that patch it complains about task_struct. > > > > > > Gaah. You'll need something like this too > > > > > > - DEFINE(TASK_CPU, offsetof(struct task_struct, cpu)); > > > + DEFINE(TASK_CPU, offsetof(struct task_struct, thread_info.cpu)); > > > > > > in arch/parisc/kernel/asm-offsets.c. > > > > > > And really, it should probably be renamed as TASK_TI_CPU, but then you > > > have to rename all the uses too. > > > > > > There might be other details like that lurking. > > > > I'll check this out too if Ard doesn't beat me to it. Thanks for the > > investigation and sorry for the breakage! > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2a2e8202c7a16a85a881ad2b6e32ccbebdc01dda Heh. Ard did, in fact, beat me to it. Thank you! :) -Kees -- Kees Cook