From: Jakub Kicinski <kuba@kernel.org>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
netdev@vger.kernel.org, Yang Yingliang <yangyingliang@huawei.com>,
davem@davemloft.net, edumazet@google.com
Subject: Re: [PATCH] ethernet: tulip: fix missing pci_disable_device() on error in tulip_init_one()
Date: Fri, 6 May 2022 09:21:52 -0700 [thread overview]
Message-ID: <20220506092152.405ce691@kernel.org> (raw)
In-Reply-To: <5564948.DvuYhMxLoT@eto.sf-tec.de>
On Fri, 06 May 2022 12:11:56 +0200 Rolf Eike Beer wrote:
> Am Freitag, 6. Mai 2022, 11:42:50 CEST schrieb Yang Yingliang:
> > Fix the missing pci_disable_device() before return
> > from tulip_init_one() in the error handling case.
>
> I would suggest removing the pci_disable_device() from tulip_remove_one()
> instead and using pcim_enable_device(), i.e. devres, and let the driver core
> handle all these things. Of course more of the used functions could be
> converted them, e.g. using devm_alloc_etherdev() and so on.
Let's not rewrite the error handling in this dinosaur of a driver
any more than absolutely necessary, please.
next prev parent reply other threads:[~2022-05-06 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 9:42 [PATCH] ethernet: tulip: fix missing pci_disable_device() on error in tulip_init_one() Yang Yingliang
2022-05-06 10:11 ` Rolf Eike Beer
2022-05-06 16:21 ` Jakub Kicinski [this message]
2022-05-11 21:55 ` Rolf Eike Beer
2022-05-09 23:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506092152.405ce691@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).