From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C9C5C43334 for ; Wed, 6 Jul 2022 19:07:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233425AbiGFTHQ (ORCPT ); Wed, 6 Jul 2022 15:07:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232935AbiGFTHP (ORCPT ); Wed, 6 Jul 2022 15:07:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B7E81C11C; Wed, 6 Jul 2022 12:07:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9716D62074; Wed, 6 Jul 2022 19:07:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66AECC3411C; Wed, 6 Jul 2022 19:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1657134434; bh=K38rVZ1m/HFXpPYNXoStTqJQXufHClahIpkV/lUJaus=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iu3oMjLgVa4VT0I8PzUHKZ8okMFKeXKQV5F7gYfc1Rs/y7wXKrjDwm9jifcHo2FwE OLlblTM1qQzekK4zwzsdoSBnhP9uPhaVqUQXy10GjMaeBtVNSXsnN9pqjplsY1CPF2 1lpdYlYRvtsiwk3uILEzHv7/7p11vvyIUoK5xbI8= Date: Wed, 6 Jul 2022 12:07:12 -0700 From: Andrew Morton To: "Fabio M. De Francesco" Cc: David Sterba , Chris Mason , Josef Bacik , Nick Terrell , linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ira Weiny , Matthew Wilcox , Kees Cook , Sebastian Andrzej Siewior , "James E. J. Bottomley" , Helge Deller , John David Anglin , linux-parisc@vger.kernel.org, David Sterba Subject: Re: [PATCH v6 1/2] highmem: Make __kunmap_{local,atomic}() take "const void *" Message-Id: <20220706120712.31b4313f17cb7ae08618c90e@linux-foundation.org> In-Reply-To: <20220706111520.12858-2-fmdefrancesco@gmail.com> References: <20220706111520.12858-1-fmdefrancesco@gmail.com> <20220706111520.12858-2-fmdefrancesco@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Wed, 6 Jul 2022 13:15:19 +0200 "Fabio M. De Francesco" wrote: > __kunmap_ {local,atomic}() currently take pointers to void. However, this > is semantically incorrect, since these functions do not change the memory > their arguments point to. > > Therefore, make this semantics explicit by modifying the > __kunmap_{local,atomic}() prototypes to take pointers to const void. > > As a side effect, compilers will likely produce more efficient code. > Acked-by: Andrew Morton Please include this in the btrfs tree if/when [2/2] is added.