From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52CCB1B5831; Mon, 9 Sep 2024 14:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725893388; cv=none; b=MRJZkoVOtXuZ2R44zkUsTiqo+RAOvw5hZScvYLpm/uDpzqmp99R5UT8wGKVI4rD6h4bkfw92+S40dosbJebuDqfc/T8h4NyhjWmTYEZxyvpAKjwyGd8txZRy8p7TDLGqxtjnLT0+CwbUIPjBlCr6rQa0EuywoVmVP2YCGSNTI0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725893388; c=relaxed/simple; bh=PokKRPH0sVJjet6Uv3//pus9g7SlpW03MFOQJoFD4Ns=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IPH78t5/QPd12qWQOdN2Hp6C1adx5p6ise+I93Xbuwoeq6JRIoQyJPCnWyuT4M8SVypeoQcLitwBfTsb+Flbs3OSoXxpPs5/DdIQepTzxOruQInoDngE2rsiTbzjaz//mVrRDl8tkuPTQpZAc2dl8w/EyDBz6MkEW8VG6cVp2iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B23C7C4CEC5; Mon, 9 Sep 2024 14:49:41 +0000 (UTC) Date: Mon, 9 Sep 2024 10:49:40 -0400 From: Steven Rostedt To: Mike Rapoport Cc: Peter Zijlstra , Andrew Morton , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text Message-ID: <20240909104940.71d8464c@gandalf.local.home> In-Reply-To: References: <20240909064730.3290724-1-rppt@kernel.org> <20240909064730.3290724-7-rppt@kernel.org> <20240909092923.GB4723@noisy.programming.kicks-ass.net> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-parisc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 9 Sep 2024 17:34:48 +0300 Mike Rapoport wrote: > > This is insane, just force BUILDTIME_MCOUNT_SORT > > The comment in ftrace.c says "... while mcount loc in modules can not be > sorted at build time" > > I don't know enough about objtool, but I'd presume it's because the sorting > should happen after relocations, no? > IIRC, the sorting at build time uses scripts/sorttable.c, which from what I can tell, only gets called on vmlinux. -- Steve