* [PATCH] parisc: perf: use named initializers for struct miscdevice
@ 2025-02-26 18:09 Thadeu Lima de Souza Cascardo
2025-02-28 7:07 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2025-02-26 18:09 UTC (permalink / raw)
To: James E.J. Bottomley, Helge Deller
Cc: linux-parisc, linux-kernel, kernel-dev,
Thadeu Lima de Souza Cascardo
Though struct miscdevice has hardly changed over the years, this is good
practice and also makes the core more readable.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
---
arch/parisc/kernel/perf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/parisc/kernel/perf.c b/arch/parisc/kernel/perf.c
index 5e8e37a722ef0fb3a22a8e0e57cb0fd48886901d..5e10f98ce7b54f75ceac1e8e5cdd1d4f752ed28f 100644
--- a/arch/parisc/kernel/perf.c
+++ b/arch/parisc/kernel/perf.c
@@ -475,9 +475,9 @@ static const struct file_operations perf_fops = {
};
static struct miscdevice perf_dev = {
- MISC_DYNAMIC_MINOR,
- PA_PERF_DEV,
- &perf_fops
+ .minor = MISC_DYNAMIC_MINOR,
+ .name = PA_PERF_DEV,
+ .fops = &perf_fops,
};
/*
---
base-commit: d082ecbc71e9e0bf49883ee4afd435a77a5101b6
change-id: 20250226-parisc-perf-miscdev-40e4642a12ec
Best regards,
--
Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] parisc: perf: use named initializers for struct miscdevice
2025-02-26 18:09 [PATCH] parisc: perf: use named initializers for struct miscdevice Thadeu Lima de Souza Cascardo
@ 2025-02-28 7:07 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2025-02-28 7:07 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo, James E.J. Bottomley
Cc: linux-parisc, linux-kernel, kernel-dev
On 2/26/25 19:09, Thadeu Lima de Souza Cascardo wrote:
> Though struct miscdevice has hardly changed over the years, this is good
> practice and also makes the core more readable.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
> ---
> arch/parisc/kernel/perf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-28 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-26 18:09 [PATCH] parisc: perf: use named initializers for struct miscdevice Thadeu Lima de Souza Cascardo
2025-02-28 7:07 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).