Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application of align

Ilpo Järvinen
2026-03-24T17:56:13Z

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

On Tue, 24 Mar 2026, John Paul Adrian Glaubitz wrote:

> Hi Ilpo,
>
> On Tue, 2026-03-24 at 18:56 +0200, Ilpo Järvinen wrote:
> > Aligning res->start by align inside pcibios_align_resource() is
> > unnecessary because caller of pcibios_align_resource() is
> > __find_resource_space() that aligns res->start with align before
> > calling pcibios_align_resource().
> >
> > Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever
> > result in changing start either because 0x300 bits would have not
> > survived the earlier alignment if align was large enough to have an
> > impact.
> >
> > Thus, remove the duplicated aligning from pcibios_align_resource().
> >
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > ---
> > arch/m68k/kernel/pcibios.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c
> > index 1415f6e4e5ce..7e286ee1976b 100644
> > --- a/arch/m68k/kernel/pcibios.c
> > +++ b/arch/m68k/kernel/pcibios.c
> > @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,
> > if ((res->flags & IORESOURCE_IO) && (start & 0x300))
> > start = (start + 0x3ff) & ~0x3ff;
> >
> > - start = (start + align - 1) & ~(align - 1);
> > -
> > return start;
> > }
> >
>
> Sorry if it's a stupid question, but what does "am68k" in the subject refer to?

The extra "a" is a typo. I'm sorry about that.

--
i.