From: Helge Deller <deller@gmx.de>
To: Sven Schnelle <svens@stackframe.org>
Cc: linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
John David Anglin <dave.anglin@bell.net>
Subject: Re: [PATCH] parisc: Prevent using same register as soure and target in extru/shr
Date: Wed, 18 May 2022 09:10:06 +0200 [thread overview]
Message-ID: <25c5c394-64a5-b14f-7c22-cc5f3a06994d@gmx.de> (raw)
In-Reply-To: <87zgjfl44f.fsf@x1.stackframe.org>
On 5/18/22 08:57, Sven Schnelle wrote:
> Helge Deller <deller@gmx.de> writes:
>
>> On 5/17/22 14:49, Helge Deller wrote:
>>> In 2004 Randolph added the shr() assembly macro and noted that the
>>> source and target register could not be the same.
>>>
>>> I did not find any confindence in the docs for this restriction. Maybe
>>> it's related that on PA2.0 the upper bits may be clobbered?
>>
>> Looking at the generated kernel code from C-files, I'll find all over usages of
>> extru source, x,y, target
>> where source and target are the same register.
>> So, at least for 32-bit this restriction can't be true.
>
> I did a quick objdump on the 64 bit HP-UX kernel and that one also uses
> extrd/extrw where target and source are the same register. So i don't
> think that restriction is true.
Thanks for checking!
Maybe it's meant that it clobbers when running *32-bit* code on PA2.0?
Just a thought...
Helge
prev parent reply other threads:[~2022-05-18 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 12:49 [PATCH] parisc: Prevent using same register as soure and target in extru/shr Helge Deller
2022-05-17 12:54 ` Helge Deller
2022-05-17 13:41 ` John David Anglin
2022-05-18 6:57 ` Sven Schnelle
2022-05-18 7:10 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25c5c394-64a5-b14f-7c22-cc5f3a06994d@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox