Re: [PATCH v3] tulip: convert to devres

Jakub Kicinski
2022-05-19T16:08:45Z

On Thu, 19 May 2022 15:40:44 +0200 Rolf Eike Beer wrote:
> Works fine on my HP C3600:
>
> [ 274.452394] tulip0: no phy info, aborting mtable build
> [ 274.499041] tulip0: MII transceiver #1 config 1000 status 782d advertising 01e1
> [ 274.750691] net eth0: Digital DS21142/43 Tulip rev 65 at MMIO 0xf4008000, 00:30:6e:08:7d:21, IRQ 17
> [ 283.104520] net eth0: Setting full-duplex based on MII#1 link partner capability of c1e1
>
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
> ---
> drivers/net/ethernet/dec/tulip/eeprom.c | 7 ++-
> drivers/net/ethernet/dec/tulip/tulip_core.c | 64 ++++++---------------
> 2 files changed, 20 insertions(+), 51 deletions(-)
>
> v2: rebased
>
> v3: fixed typo in variable for CONFIG_GSC code

Thanks for following up. Unfortunately net-next is "stable" in terms of
commits it contains, we can swap the old patch for the new one. You
need to send an incremental change.

Please provide a Fixes tag, and if you prefer to reply to something
with the patch please reply to the report of breakage, that's better
context for this work. Or just post independently (which is generally
recommended)