Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Frank Rowand <frank_rowand@hp.com>
To: Paul Bame <bame@debian.fc.hp.com>, parisc-linux@thepuffingroup.com
Subject: Re: [parisc-linux] Boot messages from C3000 console
Date: Thu, 21 Oct 1999 17:57:49 -0700	[thread overview]
Message-ID: <380FB68D.A8F28E62@hp.com> (raw)
In-Reply-To: 199910212057.OAA19923@debian.fc.hp.com

Paul Bame wrote:
> 
> This is long.  Thanks to Alex Williamson for this -
> 
> The short answer is once control is apparently transferred to the
> kernel, the system dies hard.  Someone who can read PIM dumps
> might deduce more from this log.
> 
>         -Paul Bame

< detailed HPMC info deleted>


We found it...

I'm cutting this from another discussion, don't feel like re-typing it.
The file we are talking about (giving line number references) is head.S.
We calculated the the offending offset was at label "blargh" plus a bit.

The following discussion talks about how we get to the code section
where the HPMC occurs.  Earlier, we talked about hard-coding magic
addresses, which are machine specific (that's in the macro "debug",
which is what actually caused the HPMC -- line 162).


<ggg> I was looking at how we get to blargh and don't get it. Only one
  location branches there.
> yes, it compares r28 to zero
> ah, r28 is the return value from the procedure called from line 265 (duhhhh)
> r1 is loaded at line 251 (the value of MEM_PDC, from page zero)
> That should be the entry point to PDC.
> So there's an error returned by the pdc call at line 265.
> calling PDC_BLOCK_TLB().  [arg0 = 18].  PDC_BLOCK_TLB doesn't exist on a
  PA2.0 server (and I assume the same for workstations), because block TLB
  entries don't exist, we have variable size pages instead.


Then I get a little incensed at the coding style here.... (editing out other
people's responses to my tirade)


> This is a **bogus** way to write code.  Comments should be required!!!!!! 
  Is there any way to encourage that?
> But I'm *extremely* serious about that.  This code is unmaintainable in it's
  current form.  It's going to be miserable adding 2.0 support to something
  like that.
> it's important to anyone who would like to pick up head.S and be able to
  read it.  To decode the procedure call I had to know where to find
  documentation for page zero, know what PDCE_PROC is, figure out what PDC
  procedure was being called.
> For me, it was about 45 seconds instead of the two seconds it would take to
  read a comment.
> For someone who doesn't have my background, it could be hours.


Ok, tirade mode off.  This is where my newbie status becomes apparent.  Please
excuse any foot in mouth here.  I looked at the Puffin web page and didn't
notice anything about the process of making sure that code that is submitted
has some minimal level of quality.  Is it just a matter of the community
applying peer pressure?

-Frank Rowand

  parent reply	other threads:[~1999-10-22  0:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-10-21 19:57 [parisc-linux] Boot messages from C3000 console Paul Bame
1999-10-21 21:24 ` Stan Sieler
1999-10-21 22:05 ` Frank Rowand
1999-10-21 22:51 ` Grant Grundler
1999-10-22  0:57 ` Frank Rowand [this message]
1999-10-22  2:23   ` Jason Eckhardt
1999-10-22  2:33   ` Alex deVries
1999-10-22 15:15     ` Helge Deller
1999-10-22 17:32       ` Frank Rowand
1999-10-22 23:42         ` Philipp Rumpf
1999-10-23  3:46         ` Ryan Bradetich
1999-10-22 22:16       ` Philipp Rumpf
1999-10-22 16:06     ` Grant Grundler
1999-10-24  3:44       ` [parisc-linux] Trying to boot on an N-Class Justin Hamilton
1999-10-24  5:22         ` Grant Grundler
1999-10-24  8:43         ` Philipp Rumpf
1999-10-22 22:14   ` [parisc-linux] Boot messages from C3000 console Philipp Rumpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=380FB68D.A8F28E62@hp.com \
    --to=frank_rowand@hp.com \
    --cc=bame@debian.fc.hp.com \
    --cc=frowand@cup.hp.com \
    --cc=parisc-linux@thepuffingroup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox