Re: [parisc-linux] dump driver for parisc-linux: patch vs CVS

[Bruno Vidal <bruno_vidal@hpfrcu03.france.hp.com>]

[-- Attachment #1: Type: text/plain, Size: 2907 bytes --]

	Hi.
So my work for the next few days will to create a patch
of all my modification for the latest CVS bits (so you will
have only the modifications). But I'll send it to which people ?

Grant Grundler wrote:
> As Randolph noted, we need to see the diff and what was changed
> in the generic kernel. Is the kernel and user space code GPL?

Everything is under GPL, even the code coming from SGI. I leave
all informations about the SGI code and the header of all their files.
But I've modified the code to handle specific needs for p4. I'm
also currently added code to handle multiple dump device. And I've also
the project to dump only kernel space and not user space.

> > I have modified:
> > ./Makefile
> > ./arch/parisc/config.in
> > ./arch/parisc/kernel/traps.c
> > ./arch/parisc/mm/init.c
> > ./drivers/Makefile
> > ./drivers/char/sysrq.c
> > ./init/main.c
> > ./kernel/ksyms.c
> > ./kernel/panic.c
> > ./kernel/sched.c
> 
> The last four might cause trouble....
I know, I can try to put kernel/ksyms.c to arch/parisc/kernel/parisc_ksyms.c
but it can break the code for ia64 and other architecture. but for the other
it is not possible: panic (call to dump), sched.c (another call to dump), 
main.c (init of dump). I've also an IA64 box where I can do test, so I've also
the project to do it working on it (lots of project :-).

> 
> >
> > And I've added:
> > ./include/linux/dump.h
> > ./drivers/dump/Makefile
> > ./drivers/dump/dump_base.c
> > ./drivers/dump/dump_rle.c
> > ./drivers/dump/dump_parisc.c
> 
> and we need to ask 2.4 maintainer if this can be added upstream too...
I defenitly think that it is a really needed feature (I'm working perhaps 
since a too long time in support center :-).

> 
> > So my question:
> > -Do you think it is a good idea to have a dump driver available
> > in the standart kernel ?
> 
> I do. But it's really up to linus/et al to decide that.
> I can choose to commit this code to *our* tree (parisc-linux) only.
> (and that's really not just my decision - need some consensus)

perfectly understand, so, you already have my vote :-)

> 
> > -If yes, who is able to do the code review, and put this dump
> > module in the CVS ?
> 
> Ideally, I'd like to see outstanding non-arch code changes merged
> upstream first..  Otherwise, I don't mind maintaining that code in our tree.
>
My main probleme is to have a up to date code, because I have to follow
each modification and redo the merge each time I want to update my CVS.
I agree that I need to add comments in my code, but before going further
I prefer to know if this code will stay a "patch" or not.
 
> thanks!
> grant
> 
> _______________________________________________
> parisc-linux mailing list
> parisc-linux@lists.parisc-linux.org
> http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

-- 
	Vidal Bruno, (770-4271)
        SSD-HA Team, HP-UX & LINUX Support
	bruno_vidal@admin.france.hp.com

[-- Attachment #2: Card for Bruno Vidal --]
[-- Type: text/x-vcard, Size: 386 bytes --]

begin:vcard 
n:Bruno;VIDAL
tel;fax:01-69-82-60-14
tel;work:01-69-29-42-71
x-mozilla-html:TRUE
url:www.france.hp.com
org:Solution Center
version:2.1
email;internet:bruno_vidal@hp.com
title:Expert Logiciel Environnement Haute Disponibilité
adr;quoted-printable:;;HP France=0D=0A;Z.A de Courtaboeuf;1 Av. du Canada;91947 Les Ulis cedex;France
x-mozilla-cpt:;26208
fn:VIDAL Bruno
end:vcard