Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Joel Soete <joel.soete@freebel.net>
To: John David Anglin <dave@hiauly1.hia.nrc.ca>
Cc: jsoe0708@tiscali.be, parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] Back to evms-1.0.1 && unaligne access && gdb
Date: Sat, 31 Aug 2002 21:23:59 +0000	[thread overview]
Message-ID: <3D7133EF.90602@freebel.net> (raw)
In-Reply-To: 200208301703.g7UH3TqX029540@hiauly1.hia.nrc.ca

> 
> Because the initial field of the struct is an unsigned char type,
> the cast to uint32_t is wrong.  The code is making implementation
> dependent assumptions.
> 
Finaly this trial version of function:


BOOLEAN isa_null_partition_record(struct partition *p)
{
      if (p->boot_ind == 0x00 &&
          p->head == 0x00 &&
          p->sector == 0x00 &&
          p->cyl == 0x00 &&
          p->sys_ind == 0x00 &&
          p->end_head == 0x00 &&
          p->end_sector == 0x00 &&
          p->end_cyl == 0x00 &&
          p->start_sect == 0x00 &&
          p->nr_sects == 0x00 )
          return TRUE;
      else
          return FALSE;
}

would be more portable and more easy to read and understand :<)

Thanks again for your help,
	Joel

  reply	other threads:[~2002-08-31 20:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-29  9:22 [parisc-linux] Back to evms-1.0.1 && unaligne access && gdb jsoe0708
2002-08-29  9:51 ` jsoe0708
2002-08-29 14:16   ` John David Anglin
2002-08-29 14:21   ` jsoe0708
2002-08-29 14:28     ` John David Anglin
2002-08-29 16:59       ` jsoe0708
2002-08-29 17:10         ` John David Anglin
2002-08-30  5:46           ` jsoe0708
2002-08-30 17:03             ` John David Anglin
2002-08-31 21:23               ` Joel Soete [this message]
2002-08-31 23:50                 ` Grant Grundler
2002-08-29 17:12         ` jsoe0708
2002-08-29 18:11           ` Grant Grundler
2002-08-30  5:53             ` jsoe0708
2002-08-30  6:30               ` Grant Grundler
2002-08-30  6:42                 ` jsoe0708
2002-08-29 12:42 ` Carlos O'Donell
2002-08-29 14:11 ` John David Anglin
  -- strict thread matches above, loose matches on Subject: below --
2002-08-29 13:56 jsoe0708
2002-09-02  8:47 jsoe0708
2002-09-02 17:28 ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D7133EF.90602@freebel.net \
    --to=joel.soete@freebel.net \
    --cc=dave@hiauly1.hia.nrc.ca \
    --cc=jsoe0708@tiscali.be \
    --cc=parisc-linux@lists.parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox