From: Joel Soete <soete.joel@tiscali.be>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: Randolph Chung <randolph@tausq.org>, parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] spinlock 2.4 re-organise a la 2.6 [was: [RFC] rewrite kernel spinlock code to work better with gcc]
Date: Sun, 30 Nov 2003 10:39:12 +0000 [thread overview]
Message-ID: <3FC9C8D0.6080302@tiscali.be> (raw)
In-Reply-To: <20031130033705.GA24965@colo.lackof.org>
Grant Grundler wrote:
> On Sun, Nov 30, 2003 at 12:43:51AM +0000, Joel Soete wrote:
> ...
>
>>+++ linux-2.4.23-rc5-pa17-bp/include/asm-parisc/atomic.h 2003-11-30 01:23:57.000000000 +0100
>>@@ -1,7 +1,6 @@
>> #ifndef _ASM_PARISC_ATOMIC_H_
>> #define _ASM_PARISC_ATOMIC_H_
>>
>>-#include <linux/config.h>
>> #include <asm/system.h>
>
>
> Joel,
> This is wrong - atomic.h uses CONFIG_SMP and thus is
> required to include config.h.
>
I trust you.
Just a small explanation: i was confused by the begining of asm/system.h
which is:
---------><---------
#ifndef __PARISC_SYSTEM_H
#define __PARISC_SYSTEM_H
#include <linux/config.h>
#include <asm/psw.h>
[...]
---------><---------
so I trusted that asm/system.h firstly include <linux/config.h>.
So there should be something wrong elsewhere but don't yet find.
Sorry for my bad understand,
Joel
next prev parent reply other threads:[~2003-11-30 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-26 7:07 [parisc-linux] [RFC] rewrite kernel spinlock code to work better with gcc Randolph Chung
2003-11-26 16:54 ` John David Anglin
2003-11-29 23:50 ` Joel Soete
2003-11-29 23:35 ` Joel Soete
2003-11-30 0:43 ` [parisc-linux] spinlock 2.4 re-organise a la 2.6 [was: [RFC] rewrite kernel spinlock code to work better with gcc] Joel Soete
2003-11-30 3:37 ` Grant Grundler
2003-11-30 10:39 ` Joel Soete [this message]
2003-11-30 10:57 ` Joel Soete
2003-11-30 16:31 ` Joel Soete
2003-11-30 21:10 ` Grant Grundler
2003-12-01 7:00 ` Joel Soete
2003-11-30 0:51 ` [parisc-linux] [RFC] rewrite kernel spinlock code to work better with gcc Joel Soete
2003-12-01 15:14 ` Joel Soete
2003-12-01 18:30 ` John David Anglin
2003-12-02 16:42 ` Joel Soete
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FC9C8D0.6080302@tiscali.be \
--to=soete.joel@tiscali.be \
--cc=grundler@parisc-linux.org \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox