From: Joel Soete <soete.joel@tiscali.be>
To: Randolph Chung <randolph@tausq.org>
Cc: parisc-linux@lists.parisc-linux.org
Subject: lstrncpy_from_user() additional question [Was: [parisc-linux] test case for pa_memset() ;-)]
Date: Sun, 19 Dec 2004 20:34:34 +0000 [thread overview]
Message-ID: <41C5E5DA.8000906@tiscali.be> (raw)
In-Reply-To: <20041216163417.GL29171@tausq.org>
Randolph,
I would like to get your opinion about the idea to re-write this lstrncpy_from_user() in c as you did with pa_memcpy() (may be
easiest to maintain?)
Thanks,
Joel
Randolph Chung wrote:
>>Any interest?
>>
>>This tmset3.c is a very draft and all advise will be welcome :-)
>
>
> Joel, i didn't notice earlier that you were working on memset.... i
> don't think you'll see much improvement over our current implementation.
> memcpy was a target for optimization because it used to copy
> *one-byte-at-a-time*, but our memset already knows about byte boundaries
> and tries to write more at a time when possible. i suspect you are
> seeing slower results with your implementation because of increased code
> size and branch hits. you're unlikely to see much improvement compared
> to the current version unless you either unroll the loop or do some more
> clever instruction scheduling.
>
> the three routines in arch/parisc/lib/lusercopy.S are probably better
> targets for optimization because they are all doing one-byte-at-a-time
> operations, so there is more room for improvement.
>
> randolph
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
parent reply other threads:[~2004-12-19 20:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20041216163417.GL29171@tausq.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C5E5DA.8000906@tiscali.be \
--to=soete.joel@tiscali.be \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox