From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: John David Anglin <dave.anglin@bell.net>, Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org, Deller <deller@kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH, V3] parisc: Rewrite cache flush code for PA8800/PA8900
Date: Tue, 17 May 2022 20:28:27 +0200 [thread overview]
Message-ID: <4399477.LvFx2qVVIh@daneel.sf-tec.de> (raw)
In-Reply-To: <5ea9b91f-1d64-027a-b00d-53e0ad2302ff@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
Am Dienstag, 17. Mai 2022, 20:11:38 CEST schrieb Helge Deller:
> I can easily split out the pr_warn("WARNING").
Would make sense IMHO.
> Moving the get_ptep() back to the original place seems ok, and I'll keep
> the strange indenting which checkpatch want.
If its back at the original place then there is no need to change as
checkpatch will not complain on unmodified lines. If it needs to be moved and
changed then I would say do it in it's own patch as well.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2022-05-17 18:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 15:14 [PATCH, V3] parisc: Rewrite cache flush code for PA8800/PA8900 John David Anglin
2022-05-16 21:28 ` Rolf Eike Beer
2022-05-16 21:49 ` Helge Deller
2022-05-16 22:09 ` Sam James
2022-05-16 22:24 ` Helge Deller
2022-05-16 22:54 ` Sam James
2022-05-16 23:41 ` John David Anglin
2022-05-16 22:24 ` John David Anglin
2022-05-17 13:19 ` Rolf Eike Beer
2022-05-17 13:24 ` Helge Deller
2022-05-17 14:26 ` John David Anglin
2022-05-17 18:11 ` Helge Deller
2022-05-17 18:28 ` Rolf Eike Beer [this message]
2022-05-17 18:44 ` John David Anglin
2022-05-17 20:00 ` Helge Deller
2022-05-17 20:19 ` John David Anglin
2022-05-17 18:51 ` John David Anglin
2022-05-17 13:06 ` Rolf Eike Beer
2022-05-17 14:05 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4399477.LvFx2qVVIh@daneel.sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=deller@kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox