Re: [parisc-linux] confirme: bug in arg checking in clone.S

[Joel Soete <soete.joel@tiscali.be>]

Hello Mike and list,

Mike Frysinger wrote:
> for some reason the attached test case (originally from LTP) segfaults on 
> glibc/hppa systems ... every other arch ive tested on works fine ...
> 
Ok I find this LTP Stuff.
# ./clone04
clone04     1  BROK  :  Unexpected signal 11 received.


Effectively, as the comment said:
  * DESCRIPTION
  *      Verify that,
  *      clone(2) returns -1 and sets errno to EINVAL if
  *      child stack is set to a zero value(NULL)

Also as your subject better explain, the hppa implementation didn't do a "Sanity check arguments" (as other arch does).

Can somebody could check this patch proposal:
--- ./sysdeps/unix/sysv/linux/hppa/clone.S.Orig 2006-01-14 17:48:33.000000000 +0000
+++ ./sysdeps/unix/sysv/linux/hppa/clone.S      2006-03-04 19:46:03.000000000 +0000
@@ -46,6 +46,11 @@
          .text
  ENTRY(__clone)

+       /* Sanity check arguments.  */
+       ldi     -EINVAL, %ret0
+       comib,=,n       0,%r26,.Lerror  /* no NULL function pointers */
+       comib,=,n       0,%r25,.Lerror  /* no NULL stack pointers */
+
         /* Save the fn ptr and arg on the new stack.  */
         stwm    %r26,64(%r25)
         stw     %r23,-60(%r25)
====<>====

(Not sure I didn't miss some nop in delay slot on comib?)

Thanks in advance,
	Joel
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux