Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Joel Soete <soete.joel@scarlet.be>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Parisc List <parisc-linux@lists.parisc-linux.org>
Subject: [parisc-linux] A smal chg proposal about: [PATCH] [PARISC] Allow nested interrupts
Date: Sun, 17 Sep 2006 18:09:44 +0000	[thread overview]
Message-ID: <450D8F68.7090007@scarlet.be> (raw)

Hello James,

Sorry to have read it so lately but I just figure out this:
- we can read in:
include/linux/bitops.h
--- snip ---
static inline unsigned fls_long(unsigned long l)
{
         if (sizeof(l) == 4)
                 return fls(l);
         return fls64(l);
}
--- snip ---

- otoh in your patch you wrote:
+static inline int eirr_to_irq(unsigned long eirr)
+{
+#ifdef CONFIG_64BIT
+       int bit = fls64(eirr);
+#else
+       int bit = fls(eirr);
+#endif
+       return (BITS_PER_LONG - bit) + TIMER_IRQ;
+}
+

so may be could it be simply writen:
	int bit = fls_long(eirr);

Hth,
	Joel

PS: I still have somewhere an optimized version for this stuff I will try to find it back ;-)
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

                 reply	other threads:[~2006-09-17 18:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=450D8F68.7090007@scarlet.be \
    --to=soete.joel@scarlet.be \
    --cc=James.Bottomley@SteelEye.com \
    --cc=parisc-linux@lists.parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox