From: Roel Kluin <12o3l@tiscali.nl>
To: Matthew Wilcox <matthew@wil.cx>
Cc: kyle@parisc-linux.org, grundler@parisc-linux.org,
linux-parisc@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?
Date: Mon, 11 Feb 2008 17:45:56 +0100 [thread overview]
Message-ID: <47B07BC4.9010901@tiscali.nl> (raw)
In-Reply-To: <20080211164215.GM5299@parisc-linux.org>
Matthew Wilcox wrote:
> On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote:
>> duplicate pa11_dma_alloc_consistent; more appropriate appears
>> pa11_dma_alloc_noncoherent here.
>>
>> Not tested, please confirm that this fix is correct
>
> I don't think it is. The memories are fading, so I don't recall why it
> is we do it this way, but I'm pretty sure it's correct the way it is.
>
Maybe this helps a bit: later I found that something similar occurs in
drivers/parisc/{ccio-dma.c, sba_iommu.c}:
1010: .alloc_consistent = ccio_alloc_consistent,
.alloc_noncoherent = ccio_alloc_consistent,
1036: .alloc_consistent = sba_alloc_consistent,
.alloc_noncoherent = sba_alloc_consistent,
However in these files the functions {ccio_alloc, sba_alloc}_noncoherent
do not exist.
next prev parent reply other threads:[~2008-02-11 16:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 16:23 [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent? Roel Kluin
2008-02-11 16:42 ` Matthew Wilcox
2008-02-11 16:45 ` Roel Kluin [this message]
2008-02-11 16:55 ` James Bottomley
2008-02-11 16:45 ` James Bottomley
2008-02-11 16:57 ` Roel Kluin
2008-02-11 17:08 ` [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent John David Anglin
2008-02-11 18:56 ` Roel Kluin
2008-02-11 18:58 ` Kyle McMartin
2008-02-11 19:10 ` [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent? Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B07BC4.9010901@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=grundler@parisc-linux.org \
--cc=kyle@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox