From: rubisher <rubisher@scarlet.be>
To: "Carlos O'Donell" <carlos@systemhalted.org>,
Kyle McMartin <kyle@mcmartin.ca>
Cc: linux-parisc@vger.kernel.org
Subject: [Patch] cleanup pleonasm in unaligned.c
Date: Sat, 07 Jun 2008 21:52:01 +0000 [thread overview]
Message-ID: <484B0301.2050505@scarlet.be> (raw)
Hello Carlos, Kyle,
Trying to refresh my memory about gcc "memory" clobber, I just figure out that I missed what looks to me a useless
redundancy in some FIXUP_BRANCH_CLOBBER usage in the mentioned file:
you did well:
#define FIXUP_BRANCH_CLOBBER "r1"
I think so what is following is just a cleanup which wouldn't affect the generated code, even thought:
--- ./a/arch/parisc/kernel/unaligned.c 2008-05-17 16:44:35.000000000 +0000
+++ ./b/arch/parisc/kernel/unaligned.c 2008-06-07 21:30:56.000000000 +0000
@@ -350,7 +350,7 @@
ASM_EXCEPTIONTABLE_ENTRY(2b,4b)
: "=r" (ret)
: "r" (val), "r" (regs->ior), "r" (regs->isr)
- : "r19", "r20", "r21", "r22", "r1", FIXUP_BRANCH_CLOBBER );
+ : "r19", "r20", "r21", "r22", FIXUP_BRANCH_CLOBBER );
return 0;
}
@@ -402,7 +402,7 @@
ASM_EXCEPTIONTABLE_ENTRY(4b,6b)
: "=r" (ret)
: "r" (val), "r" (regs->ior), "r" (regs->isr)
- : "r19", "r20", "r21", "r22", "r1", FIXUP_BRANCH_CLOBBER );
+ : "r19", "r20", "r21", "r22", FIXUP_BRANCH_CLOBBER );
#else
{
unsigned long valh=(val>>32),vall=(val&0xffffffffl);
@@ -437,7 +437,7 @@
ASM_EXCEPTIONTABLE_ENTRY(5b,7b)
: "=r" (ret)
: "r" (valh), "r" (vall), "r" (regs->ior), "r" (regs->isr)
- : "r19", "r20", "r21", "r1", FIXUP_BRANCH_CLOBBER );
+ : "r19", "r20", "r21", FIXUP_BRANCH_CLOBBER );
}
#endif
=== <> ===
What's your opinion?
Cheers,
r.
reply other threads:[~2008-06-07 21:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484B0301.2050505@scarlet.be \
--to=rubisher@scarlet.be \
--cc=carlos@systemhalted.org \
--cc=kyle@mcmartin.ca \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox