From: Helge Deller <deller@gmx.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>, linux-parisc@vger.kernel.org
Subject: Re: [RESEND] [PATCH] convert sticore.c to PCI ROM API
Date: Sun, 08 Jun 2008 18:24:29 +0200 [thread overview]
Message-ID: <484C07BD.8090308@gmx.de> (raw)
In-Reply-To: <1212794861.16182.39.camel@localhost.localdomain>
James Bottomley wrote:
> On Fri, 2008-06-06 at 22:35 +0200, Krzysztof Helt wrote:
>> On Thu, 05 Jun 2008 17:26:54 -0500
>> James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>>
>>> I'm really not sure this is such a good idea. pci_map_rom() can do an
>>> ioremap() on the region. In that case, gsc_readl which punches through
>>> our virtual memory into physical I/O space will fail. What assurance do
>>> we have that all STI roms are correctly set up so pci_map_rom() isn't
>>> inclined to ioremap them?
>>>
>> I haven't thought about this. The ROM the Helge tested was obviously
>> set up correctly, otherwise reading the ROM signature would be impossible.
>
> I suspect Helge only tested GSC based cards, which will work just fine
> because they use the old logic.
No, tested on Tadpole Laptop (7100LC) and c3k with VisEG PCI.
But it's OK that the patch was dropped...
Helge
next prev parent reply other threads:[~2008-06-08 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 21:13 [RESEND] [PATCH] convert sticore.c to PCI ROM API Krzysztof Helt
2008-06-05 22:11 ` Andrew Morton
2008-06-06 18:52 ` Krzysztof Helt
2008-06-05 22:26 ` James Bottomley
2008-06-06 20:35 ` Krzysztof Helt
2008-06-06 23:27 ` James Bottomley
2008-06-07 9:08 ` Krzysztof Helt
2008-06-07 20:34 ` Grant Grundler
2008-06-08 16:24 ` Helge Deller [this message]
2008-06-06 21:23 ` Helge Deller
[not found] <159459.29885.qm@web32505.mail.mud.yahoo.com>
2008-06-07 17:25 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2008-06-07 20:51 Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484C07BD.8090308@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox