* [RFC PATCH 9/9] parisc: allocate sys_membarrier system call number
[not found] <1440698215-8355-1-git-send-email-mathieu.desnoyers@efficios.com>
@ 2015-08-27 17:56 ` Mathieu Desnoyers
[not found] ` <1440698215-8355-10-git-send-email-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Desnoyers @ 2015-08-27 17:56 UTC (permalink / raw)
To: Andrew Morton, linux-api
Cc: linux-kernel, Mathieu Desnoyers, James E.J. Bottomley,
Helge Deller, linux-parisc
[ Untested on this architecture. To try it out: fetch linux-next/akpm,
apply this patch, build/run a membarrier-enabled kernel, and do make
kselftest. ]
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: linux-api@vger.kernel.org
CC: "James E.J. Bottomley" <jejb@parisc-linux.org>
CC: Helge Deller <deller@gmx.de>
CC: linux-parisc@vger.kernel.org
---
arch/parisc/include/uapi/asm/unistd.h | 3 ++-
arch/parisc/kernel/syscall_table.S | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/parisc/include/uapi/asm/unistd.h b/arch/parisc/include/uapi/asm/unistd.h
index 2e639d7..dadcada 100644
--- a/arch/parisc/include/uapi/asm/unistd.h
+++ b/arch/parisc/include/uapi/asm/unistd.h
@@ -358,8 +358,9 @@
#define __NR_memfd_create (__NR_Linux + 340)
#define __NR_bpf (__NR_Linux + 341)
#define __NR_execveat (__NR_Linux + 342)
+#define __NR_membarrier (__NR_Linux + 343)
-#define __NR_Linux_syscalls (__NR_execveat + 1)
+#define __NR_Linux_syscalls (__NR_membarrier + 1)
#define __IGNORE_select /* newselect */
diff --git a/arch/parisc/kernel/syscall_table.S b/arch/parisc/kernel/syscall_table.S
index 8eefb12..2faa43b 100644
--- a/arch/parisc/kernel/syscall_table.S
+++ b/arch/parisc/kernel/syscall_table.S
@@ -438,6 +438,7 @@
ENTRY_SAME(memfd_create) /* 340 */
ENTRY_SAME(bpf)
ENTRY_COMP(execveat)
+ ENTRY_COMP(membarrier)
.ifne (. - 90b) - (__NR_Linux_syscalls * (91b - 90b))
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH 9/9] parisc: allocate sys_membarrier system call number
[not found] ` <1440698215-8355-10-git-send-email-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
@ 2015-09-03 12:26 ` Helge Deller
2015-09-03 15:41 ` Mathieu Desnoyers
0 siblings, 1 reply; 3+ messages in thread
From: Helge Deller @ 2015-09-03 12:26 UTC (permalink / raw)
To: Mathieu Desnoyers
Cc: Andrew Morton, linux-api-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, James E.J. Bottomley,
linux-parisc-u79uwXL29TY76Z2rM5mHXA
Hi Mathieu,
> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
> apply this patch, build/run a membarrier-enabled kernel, and do make
> kselftest. ]
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
> CC: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
> CC: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> CC: "James E.J. Bottomley" <jejb-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>
> CC: Helge Deller <deller-Mmb7MZpHnFY@public.gmane.org>
> CC: linux-parisc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> ---
> arch/parisc/include/uapi/asm/unistd.h | 3 ++-
> arch/parisc/kernel/syscall_table.S | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/parisc/include/uapi/asm/unistd.h b/arch/parisc/include/uapi/asm/unistd.h
> index 2e639d7..dadcada 100644
> --- a/arch/parisc/include/uapi/asm/unistd.h
> +++ b/arch/parisc/include/uapi/asm/unistd.h
> @@ -358,8 +358,9 @@
> #define __NR_memfd_create (__NR_Linux + 340)
> #define __NR_bpf (__NR_Linux + 341)
> #define __NR_execveat (__NR_Linux + 342)
> +#define __NR_membarrier (__NR_Linux + 343)
>
> -#define __NR_Linux_syscalls (__NR_execveat + 1)
> +#define __NR_Linux_syscalls (__NR_membarrier + 1)
>
>
> #define __IGNORE_select /* newselect */
> diff --git a/arch/parisc/kernel/syscall_table.S b/arch/parisc/kernel/syscall_table.S
> index 8eefb12..2faa43b 100644
> --- a/arch/parisc/kernel/syscall_table.S
> +++ b/arch/parisc/kernel/syscall_table.S
> @@ -438,6 +438,7 @@
> ENTRY_SAME(memfd_create) /* 340 */
> ENTRY_SAME(bpf)
> ENTRY_COMP(execveat)
> + ENTRY_COMP(membarrier)
This needs to be ENTRY_SAME(membarrier), since you don't have/need a compat_membarrier() function.
After changing to ENTRY_SAME() I did run the kselftest on parisc:
deller@ls3xx> ./membarrier_test
membarrier MEMBARRIER_CMD_QUERY syscall available.
membarrier: MEMBARRIER_CMD_SHARED success.
membarrier: tests done!
Helge
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH 9/9] parisc: allocate sys_membarrier system call number
2015-09-03 12:26 ` Helge Deller
@ 2015-09-03 15:41 ` Mathieu Desnoyers
0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Desnoyers @ 2015-09-03 15:41 UTC (permalink / raw)
To: Helge Deller
Cc: Andrew Morton, linux-api, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
James E.J. Bottomley, linux-parisc-u79uwXL29TY76Z2rM5mHXA
----- On Sep 3, 2015, at 8:26 AM, Helge Deller deller-Mmb7MZpHnFY@public.gmane.org wrote:
> Hi Mathieu,
>
>> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
>> apply this patch, build/run a membarrier-enabled kernel, and do make
>> kselftest. ]
>>
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
>> CC: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
>> CC: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> CC: "James E.J. Bottomley" <jejb-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>
>> CC: Helge Deller <deller-Mmb7MZpHnFY@public.gmane.org>
>> CC: linux-parisc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> ---
>> arch/parisc/include/uapi/asm/unistd.h | 3 ++-
>> arch/parisc/kernel/syscall_table.S | 1 +
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/parisc/include/uapi/asm/unistd.h
>> b/arch/parisc/include/uapi/asm/unistd.h
>> index 2e639d7..dadcada 100644
>> --- a/arch/parisc/include/uapi/asm/unistd.h
>> +++ b/arch/parisc/include/uapi/asm/unistd.h
>> @@ -358,8 +358,9 @@
>> #define __NR_memfd_create (__NR_Linux + 340)
>> #define __NR_bpf (__NR_Linux + 341)
>> #define __NR_execveat (__NR_Linux + 342)
>> +#define __NR_membarrier (__NR_Linux + 343)
>>
>> -#define __NR_Linux_syscalls (__NR_execveat + 1)
>> +#define __NR_Linux_syscalls (__NR_membarrier + 1)
>>
>>
>> #define __IGNORE_select /* newselect */
>> diff --git a/arch/parisc/kernel/syscall_table.S
>> b/arch/parisc/kernel/syscall_table.S
>> index 8eefb12..2faa43b 100644
>> --- a/arch/parisc/kernel/syscall_table.S
>> +++ b/arch/parisc/kernel/syscall_table.S
>> @@ -438,6 +438,7 @@
>> ENTRY_SAME(memfd_create) /* 340 */
>> ENTRY_SAME(bpf)
>> ENTRY_COMP(execveat)
>> + ENTRY_COMP(membarrier)
>
> This needs to be ENTRY_SAME(membarrier), since you don't have/need a
> compat_membarrier() function.
Allright, will fix.
>
> After changing to ENTRY_SAME() I did run the kselftest on parisc:
> deller@ls3xx> ./membarrier_test
> membarrier MEMBARRIER_CMD_QUERY syscall available.
> membarrier: MEMBARRIER_CMD_SHARED success.
> membarrier: tests done!
And add your Tested-by tag, thanks!
Mathieu
>
> Helge
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-03 15:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1440698215-8355-1-git-send-email-mathieu.desnoyers@efficios.com>
2015-08-27 17:56 ` [RFC PATCH 9/9] parisc: allocate sys_membarrier system call number Mathieu Desnoyers
[not found] ` <1440698215-8355-10-git-send-email-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-09-03 12:26 ` Helge Deller
2015-09-03 15:41 ` Mathieu Desnoyers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).