Re: [PATCH] mips: Add dma_mmap_coherent()

[Joel Soete <soete.joel@scarlet.be>]

Hello Takashi,

Takashi Iwai wrote:
> At Fri, 22 Aug 2008 13:04:36 +0100,
> Joel Soete wrote:
>> Hello Takashi et al.,
> ...
>> I build and boot successfully kernel 32bit including your patch on 2 systems
>> (a b2k using sba and a d380 using ccio).
> 
> Thanks for testing!
> 
welcome ;-)

>> I just noticed that the above code is ~ the same; otoh there is also a
>> iommu-helpers.h containing also common code to those 2 drivers. So may be for
>> easiest maintenance, could you merge and move this code in this 'helper' as
>> follow:
>> --- ./drivers/parisc/iommu-helpers.h.Orig	2008-08-01 12:57:22.000000000 +0000
>> +++ ./drivers/parisc/iommu-helpers.h	2008-08-22 08:07:26.000000000 +0000
> 
> That sounds like a good idea.
> 
> One concern is to define a non-inline function in *.h.  But,

Yes (I thought too but didn't find any other good reason then avoiding useless duplicate code)

> iommu-helper.h is included only by these two drivers, so there is no
> problem as now, although a comment would be more helpful.
> 
Yes I hope it will be enough for this stuff to be accepted ;-)

> 
>>> diff --git a/include/asm-parisc/dma-mapping.h b/include/asm-parisc/dma-mapping.h
>>> index 53af696..5b357b3 100644
>>> --- a/include/asm-parisc/dma-mapping.h
>>> +++ b/include/asm-parisc/dma-mapping.h
>> The small issue encountered: against latest Kyle git tree (dated 2008-07-29)
>> this file was moved in arch/parisc/include/asm.
> 
> Yes.  My patches are still based on older version (2.6.27-rc2 or so).
> 
> git cares renaming well, so it shouldn't be a big problem.
> I just tested it now and git-pull (oh now it's "git pull" :) renames
> it automatically indeed.
> 
Cool (tbh I know very few about git just git clone to grab a tree and git pull to get update from time to time ;-))

> 
> thanks,
> 
> Takashi
> --
Tx to your attention,
	J.