From: Helge Deller <deller@gmx.de>
To: Randolph Chung <randolph@tausq.org>
Cc: linux-parisc@vger.kernel.org,
Kyle Mc Martin <kyle@hera.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] parisc: fix kernel crash when unwinding a userspace process
Date: Fri, 21 Nov 2008 15:02:22 +0100 [thread overview]
Message-ID: <4926BF6E.3050907@gmx.de> (raw)
In-Reply-To: <49268965.7010401@tausq.org>
Randolph Chung wrote:
> Helge Deller wrote:
>> Any user on existing parisc 32- and 64bit-kernels can easily crash
>> the kernel and as such enforce a DSO.
>> A simple testcase is available here:
>> http://gsyprf10.external.hp.com/~deller/crash.tgz
>>
>> The problem is introduced by the fact, that the handle_interruption()
>> crash handler calls the show_regs() function, which in turn tries
>> to unwind the stack by calling parisc_show_stack().
>> Since the stack contains userspace addresses, a try to unwind the
>> stack is dangerous and useless and leads to the crash.
>
> Helge,
>
> I think this is ok, but can you preserve the printing of IAOQ/RP even
> for user processes?
Thanks Randolph,
You are probably right. It's better to stay consistent for debugging and
you'll see the important registers at once.
I'll respin a new patch.
Helge
next prev parent reply other threads:[~2008-11-21 14:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 21:58 [PATCH] parisc: fix kernel crash when unwinding a userspace process Helge Deller
2008-11-21 10:11 ` Randolph Chung
2008-11-21 14:02 ` Helge Deller [this message]
2008-11-21 14:16 ` [PATCH] parisc: fix kernel crash when unwinding a userspace process (v2) Helge Deller
2008-11-21 19:17 ` Andrew Morton
2008-11-21 22:00 ` Helge Deller
2008-11-21 22:20 ` Andrew Morton
2008-11-22 5:53 ` Grant Grundler
2008-11-22 12:22 ` Matthew Wilcox
2008-11-22 18:01 ` Grant Grundler
2008-11-22 20:09 ` Helge Deller
2008-12-01 7:21 ` [PATCH] 2.6.28-rc6 update parisc MAINTAINERS Grant Grundler
2008-12-01 15:59 ` Helge Deller
2008-12-03 8:22 ` Grant Grundler
2008-11-25 17:20 ` [PATCH] parisc: fix kernel crash when unwinding a userspace process (v2) Kyle McMartin
2008-11-26 2:47 ` Grant Grundler
2008-11-26 2:59 ` Kyle McMartin
2008-11-25 17:03 ` [PATCH] parisc: fix kernel crash when unwinding a userspace process Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4926BF6E.3050907@gmx.de \
--to=deller@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=kyle@hera.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox